Conversation
In order to better support maps between (co)homology groups the current code need reorganising. This introduces the first step: free resolutions of ZG (well, the 1st 3 terms - enough to get H^2) as a proper complex as well as a "hom-functor". It relies on the corresponding changes in AA and Hecke. Will/ should be continued with - tensor produc functor - homology - enough interfaces to remove the old H^? code ... small steps ...
Collaborator
|
Do you want to add this as an example/test somewhere? |
Member
|
When I try the example, (Sorry, I missed the info that dev versions of AbstractAlgebra and Hecke are needed. Will try again.) |
Contributor
Author
|
this test is wrong - this is the mixup with the FundClass and the MeatAxe branches |
Contributor
Author
|
So, the interface is slowly emerging
|
| fr = Oscar.GrpCoh.free_res(ZG; side = :right) | ||
| h = hom(fr, I.data[1]) | ||
| @test is_isomorphic(abelian_group([6]), quo(kernel(map(h, 2))[1], image(map(h, 1))[1])[1]) | ||
| @test is_isomorphic(abelian_group([1]), quo(kernel(map(h, 1))[1], image(map(h, 1))[0])[1]) |
Member
There was a problem hiding this comment.
Suggested change
| @test is_isomorphic(abelian_group([1]), quo(kernel(map(h, 1))[1], image(map(h, 1))[0])[1]) | |
| @test is_isomorphic(abelian_group([1]), quo(kernel(map(h, 1))[1], image(map(h, 0))[1])[1]) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the following to work:
to compute (co)-homology like in the text book. Not yet perfect.