Fix deserialization of MatGroup#5883
Conversation
|
Ok, so it seems that |
The update sript for version 1.4.0 can create dictionaries which have a `:name` but no `:params`, The function `rename_types` was not aware of that.
I don't see why this would be necessary, the type names should be in the _type / params
this didn't break loading but doesn't work well with subsequent upgrades
|
I added three examples here: oscar-system/serialization-upgrade-tests#13 I set |
|
Concerning the commit "dont recurse into :data section for type rename": |
avoid using leech pairs from experimental
In theory, types names should not be within the data section, but we had some cases where this was violated. There were some fixes regarding this at some point but I don't remember when exactly. |
|
Thanks @benlorenz! I would approve, but that's not possible because this is formally my own PR. Once the hash has been updated to the merge commit of oscar-system/serialization-upgrade-tests#13, this is good to go from my POV. |
Co-authored-by: ThomasBreuer <sam@math.rwth-aachen.de> Co-authored-by: Benjamin Lorenz <lorenz@math.tu-berlin.de>
Resolves #5882 by adding an upgrade script.
I am not quite sure if I assembled the upgrade script in the right way, as there was no pure renaming since we have
upgrade_recursive. In particular, I am not sure ifupgrade_recursiveneeds to be called.As the corresponding renaming was already released with Oscar 1.7.0, IMO we should backport this asap. (cc @benlorenz @aaruni96 )