Zlattices - primitive embedding with roots in orthogonal#5888
Merged
simonbrandhorst merged 11 commits intooscar-system:masterfrom Apr 24, 2026
Merged
Zlattices - primitive embedding with roots in orthogonal#5888simonbrandhorst merged 11 commits intooscar-system:masterfrom
simonbrandhorst merged 11 commits intooscar-system:masterfrom
Conversation
…nk st the orthogonal complement has the most roots
lgoettgens
reviewed
Mar 25, 2026
Collaborator
|
I will review this, once it is ready :-). Thanks for the PR. |
simonbrandhorst
requested changes
Apr 16, 2026
Collaborator
simonbrandhorst
left a comment
simonbrandhorst
left a comment
There was a problem hiding this comment.
Many thanks for this PR. It is a very good first draft.
I have just some minor stylistic remarks.
| SR, inj = direct_sum(S, R) | ||
| iS, iR = inj | ||
| V = ambient_space(SR) | ||
| S = lattice(V, basis_matrix(S) * iS.matrix) |
Collaborator
There was a problem hiding this comment.
Does iS(S) work?. If not, then I think we should make it work. (but not in this PR)
simonbrandhorst
added
the
release notes: not needed
Collaborator
simonbrandhorst
left a comment
simonbrandhorst
left a comment
There was a problem hiding this comment.
Just a final comment on the docstring :-).
Co-authored-by: Simon Brandhorst <brandhorst@math.uni-sb.de>
Co-authored-by: Simon Brandhorst <brandhorst@math.uni-sb.de>
simonbrandhorst
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
primitive embedding of a hyperbolic lattice in a unimodular of given rank st the orthogonal complement has the most roots