Fix bug in diff_action and provide convenience constructors#5892
Merged
lgoettgens merged 4 commits intooscar-system:masterfrom Mar 25, 2026
Merged
Fix bug in diff_action and provide convenience constructors#5892lgoettgens merged 4 commits intooscar-system:masterfrom
diff_action and provide convenience constructors#5892lgoettgens merged 4 commits intooscar-system:masterfrom
Conversation
SirToby25
added
enhancement
lgoettgens
reviewed
Mar 25, 2026
Member
lgoettgens
left a comment
lgoettgens
left a comment
There was a problem hiding this comment.
doctests don't go well with comments. these two suggestions should fix that
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Collaborator
Author
It seems that way. Thank you for the suggestions |
lgoettgens
changed the title
lgoettgens
approved these changes
Mar 25, 2026
lgoettgens
changed the title
diff_action and provide convenience constructors
lgoettgens
added
release notes: use title
benlorenz
pushed a commit
that referenced
this pull request
Mar 25, 2026
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com> (cherry picked from commit e2da678)
benlorenz
added
backport 1.7.x done
and removed
backport 1.7.x
enhancement
benlorenz
referenced
this pull request
Mar 26, 2026
Kazak-11
pushed a commit
to Kazak-11/Oscar.jl
that referenced
this pull request
Apr 2, 2026
…system#5892) Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR fixes a bug in the
diff_action-method for difference polynomial rings: After calculating the position of the new exponents the entries in the previous positions were killed, which caused an error if a new position coincided with an old one. This is now fixed and a test was added.Additionally, we provide a new constructor for difference and differential polynomial rings respectively. It takes a single symbol instead of a vector of symbols. Using it is more convenient when one want to construct such a ring while storing its single jet variable at the same time. The docs were updated accordingly.