Fix a bug that could prevent loading some serialized data#5906
Merged
simonbrandhorst merged 4 commits intomasterfrom Apr 7, 2026
Merged
Fix a bug that could prevent loading some serialized data#5906simonbrandhorst merged 4 commits intomasterfrom
simonbrandhorst merged 4 commits intomasterfrom
Conversation
antonydellavecchia
added
serialization
release notes: not needed
Collaborator
|
Thank you so much. Would it make sense to add a test to make sure the bug stays fixed? |
Collaborator
Author
|
first we test on this commit oscar-system/serialization-upgrade-tests#14 |
Member
|
This is marked as not needing a release note. But it also sounds as if deserialization for certain files is broken? In that case, shouldn't we mention it in the release notes so that anyone affected has a chance to see it there, and think "oohh maybe that means I can recover that file that didn't work" ? |
simonbrandhorst
approved these changes
Apr 7, 2026
simonbrandhorst
added
release notes: use title
benlorenz
pushed a commit
that referenced
this pull request
Apr 8, 2026
(cherry picked from commit 7caee99)
Merged
fingolfin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix for recursive upgrade with Dict with integer keys.
Bug fix for renaming when a Dict is part of the file