read_metadata: use JSON for reading metadata to preserve order#5914
Merged
read_metadata: use JSON for reading metadata to preserve order#5914
Conversation
using lazy parsing to avoid reading the full file fixes doctests with JSON.jl version 1.5.0
antonydellavecchia
approved these changes
Apr 2, 2026
benlorenz
added
backport 1.7.x
release notes: not needed
This was referenced Apr 7, 2026
benlorenz
added a commit
that referenced
this pull request
Apr 8, 2026
using lazy parsing to avoid reading the full file fixes doctests with JSON.jl version 1.5.0 (cherry picked from commit 862f791)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes failing doctests with JSON.jl version 1.5.0 (which added a default sorting, for objects which are not native JSON Objects).
Adding a
sort_keyskeyword or changing the output would make it dependent on the JSON version, this way it should be independent.Using lazy parsing to avoid materializing the whole file as an object.