Skip to content

Fix parent of the generators of the ideal returned from groebner_basis_f4 when used with eliminate > 0#5918

Merged
fingolfin merged 5 commits intomasterfrom
adv/vanishing-ideal-f4
Apr 8, 2026
Merged

Fix parent of the generators of the ideal returned from groebner_basis_f4 when used with eliminate > 0#5918
fingolfin merged 5 commits intomasterfrom
adv/vanishing-ideal-f4

Conversation

@antonydellavecchia
Copy link
Copy Markdown
Collaborator

@antonydellavecchia antonydellavecchia commented Apr 7, 2026 •
edited
Loading

Adjustments so that the parent ring of the generators is the same as the base ring of the ideal after an f4 eliminate.

@antonydellavecchia antonydellavecchia added embarrassing-bugfix Whoops! experimental Only changes experimental parts of the code release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Apr 7, 2026
@antonydellavecchia antonydellavecchia marked this pull request as draft April 7, 2026 10:28
@antonydellavecchia antonydellavecchia added topic: commutative algebra and removed embarrassing-bugfix Whoops! experimental Only changes experimental parts of the code labels Apr 7, 2026
@antonydellavecchia antonydellavecchia marked this pull request as ready for review April 7, 2026 13:10
@antonydellavecchia antonydellavecchia changed the title Fix vanishing_ideal for graphical models when using f4 Fix parent in ideal returned from groebner_basis_f4 when used with eliminate > 0 Apr 7, 2026
@lgoettgens lgoettgens requested a review from ederc April 7, 2026 13:20
@oscar-system oscar-system locked and limited conversation to collaborators Apr 8, 2026
@antonydellavecchia
Copy link
Copy Markdown
Collaborator Author

antonydellavecchia commented Apr 8, 2026

Not sure how I ended up locking this conversation, but I am not sure how to unlock it? I guess it won't really matter.

@oscar-system oscar-system unlocked this conversation Apr 8, 2026
@fingolfin fingolfin changed the title Fix parent in ideal returned from groebner_basis_f4 when used with eliminate > 0 Fix parent in ideal returned from groebner_basis_f4 when used with eliminate > 0 Apr 8, 2026
@fingolfin fingolfin changed the title Fix parent in ideal returned from groebner_basis_f4 when used with eliminate > 0 Fix parent in ideal returned from groebner_basis_f4 when used with eliminate > 0 Apr 8, 2026
@fingolfin fingolfin changed the title Fix parent in ideal returned from groebner_basis_f4 when used with eliminate > 0 Fix parent of the generators of the ideal returned from groebner_basis_f4 when used with eliminate > 0 Apr 8, 2026
@fingolfin fingolfin added the bug Something isn't working label Apr 8, 2026
@fingolfin fingolfin enabled auto-merge (squash) April 8, 2026 10:45
@fingolfin fingolfin merged commit 9f41c65 into master Apr 8, 2026
41 of 42 checks passed
@fingolfin fingolfin deleted the adv/vanishing-ideal-f4 branch April 8, 2026 11:43
@benlorenz benlorenz mentioned this pull request Apr 8, 2026
Merged
benlorenz pushed a commit that referenced this pull request Apr 8, 2026
@antonydellavecchia @benlorenz
Fix return value of groebner_basis_f4 with eliminate > 0 (#5918)
d6b857b 
Ensure the parent ring of the generators in the returned ideal
is the same as the base ring of the ideal after an f4 eliminate

(cherry picked from commit 9f41c65)
benlorenz referenced this pull request Apr 8, 2026
@benlorenz
backports for 1.7.2 (#5920)
d84a5c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ederc ederc ederc approved these changes

Assignees

No one assigned

Labels

backport 1.7.x done bug Something isn't working release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: commutative algebra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antonydellavecchia @ederc @fingolfin @benlorenz