Fix normal_form for module orderings other than the default ordering #5934
Merged
fingolfin merged 4 commits intooscar-system:masterfrom Apr 15, 2026
Merged
Fix normal_form for module orderings other than the default ordering #5934fingolfin merged 4 commits intooscar-system:masterfrom
fingolfin merged 4 commits intooscar-system:masterfrom
Conversation
ederc
added
bug
ederc
approved these changes
Apr 13, 2026
Contributor
Author
|
@ederc could you merge this PR, since I do not have write permissions? |
Contributor
Author
|
Ping @afkafkafk13 |
Syz-MS
added a commit
to Syz-MS/Oscar.jl
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5933.
Adds to
singular_generators(M::ModuleGens)the option to specify aModuleOrderingto be able to hand the generators ofMdown to singular with different ordering than the one stored inM.Changes
normal_form(M, GB)to pass the generators of the ModuleGensMdown to Singular with the ordering of the given Groebner basisGB.