Serialize small Ints as JSON Ints#5947
Open
antonydellavecchia wants to merge 13 commits intomasterfrom
Open
Conversation
lgoettgens
reviewed
Apr 16, 2026
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
…o adv/optimize-serialize-ints
Collaborator
Author
|
handles part of #5482 |
benlorenz
reviewed
Apr 22, 2026
Member
benlorenz
left a comment
There was a problem hiding this comment.
Did you do any tests how this affects size and loading / savingspeed for any of the very large files that we have?
Collaborator
Author
|
this branch timings/allocations and filesize current master timings timings/allocations and filesize |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialize Integers between 1 - 2^53 and 2^53 -1 as JSON numbers.
possible this wont need upgrade, but will see what tests say.