refactor: computations of primitive embeddings and extensions of ZZLat#5949
Draft
StevellM wants to merge 5 commits intooscar-system:masterfrom
Draft
refactor: computations of primitive embeddings and extensions of ZZLat#5949StevellM wants to merge 5 commits intooscar-system:masterfrom
ZZLat#5949StevellM wants to merge 5 commits intooscar-system:masterfrom
Conversation
StevellM
added
topic: number theory
WIP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress on improving the machinery for computing primitive embeddings/extensions of
ZZLat. The main changes currently are:I would say that currently, the draft contains approximately 45% of the final changes. Open a draft to keep track of current changes but also to give a working version to anyone interested.
Most of what is missing is user interface, corner cases, documentation and tests. All the part about equivariant extensions is also missing and will be added once the "plain" case is complete and stabilized. The overall new infrastructure is here and should stay as is in the future (modulo some fine-tuning).
Related to #5726