Logo is not visible on presets with different preserve tag values

[Oivo35]

Logos should also be visible on presets if there are different preserve tag values.

Example:
Selecta vending machine

Selecta preset with both preserve tag values

Selecta preset with diferent preserve tag values

[bhousel]

I'm not sure whether...
... this would be a change to be made on the iD side (matching the preset partially if the tag is semicolon-delimited is not likely to happen).

...or whether it's an issue on the NSI side (are we suggesting a dumb vending= tag here? The vending=drinks;sweets implies that all these machines do both things, which is probably wrong.)

[Oivo35]

I think NSI data are correct. It seems that iD doesn't recognize the preset and wikidata.

Another example:
Stop Cafe
All Stop Cafe shops offers at least coffee, but some also fresh food and therefore mappers often add additional cuisine values.

Stop Cafe preset with only cuisine=coffee_shop (with preserveTags: ^cuisine$)

The same Stop Cafe preset with additional cuisine values (with preserveTags: ^cuisine$)

However, iD recognizes presets with "preserveTags": ["^name"], even if the name tag contains different name or a semicolon.

[bhousel]

ok - iD is only using the preserveTags property when the validator recommends tag changes. It doesn't use that for preset matching, and I wouldn't really expect it to do this.

The Preset system uses whatever tags we have set in the preset. For Stop Cafe, it looks like this:

    "amenity/cafe/coffee_shop/stopcafe-7e9986": {    // the preset id
      "name": "Stop Cafe",
      "locationSet": {"include": ["cz", "hu", "lt", "pl", "sk"]},
      "icon": "temaki-hot_drink_cup",
      "geometry": ["point", "area"],
      "matchScore": 2,
      "imageURL": "https://graph.facebook.com/stopcafecz/picture?type=large",
      "terms": ["stop cafe"],
      "reference": {"key": "cuisine", "value": "coffee_shop"},
      "preserveTags": ["^cuisine$"],     // iD doesn't care about this property
      "tags": {
        "amenity": "cafe",                  // These are the tags that iD
        "brand:wikidata": "Q130868061",     // looks at when it matches
        "cuisine": "coffee_shop"            // the "Stop Cafe" preset
      },
      "addTags": {
        "amenity": "cafe",
        "brand": "Stop Cafe",
        "brand:wikidata": "Q130868061",
        "cuisine": "coffee_shop",
        "name": "Stop Cafe",
        "takeaway": "yes"
      }
    },

So - if you remove the cuisine=coffee_shop it's no longer considered a "Stop Cafe".

The reason it is like this is because: our script that generates the presets knows that iD has a preset for amenity=cafe + cuisine=coffee_shop identified by amenity/cafe/coffee_shop (in iD it shows up as a "Coffeehouse") and our script appends the "Stop Cafe" preset off the end of that existing chain of tags.

It makes sense to me why the presets are working this way - but I can see how it would be confusing for other people who start changing tags and wonder why the presets stop matching.