Upgrade to Laravel 7

[RossAHC]

No description provided.

[MrReeds]

+1

[MrReeds]

seems to have all that is needed

[cwilby]

@MrReeds does @anteriovieira need to approve these changes to merge the PR?

[MrReeds]

@MrReeds does @anteriovieira need to approve these changes to merge the PR?

seems so, only authorized people are allowed

[MammutAlex]

@anteriovieira Hi,
I don't mean to push you but this is the only package holding me back from upgrading my application to Laravel 7.x

Do you happen to know when you can approve the request?

[efriandika]

TOP

[thierrydrc]

Up please !

[aglipanci]

I configured Scrutinizer and Travis to my fork with this PR merged and all the tests passed.

https://travis-ci.org/aglipanci/laravel-auditing/builds/659942480
https://scrutinizer-ci.com/g/aglipanci/laravel-auditing/inspections/3567875c-9e77-4844-b7ea-4e23b382960b

[cwilby]

Switched to https://altek.gitlab.io/accountant/. It's a fork by the previous maintainer @quetzyg that already supports L7 and stores changes differently.

[aglipanci]

Switched to https://altek.gitlab.io/accountant/. It's a fork by a maintainer that already supports L7 and stores changes differently.

Can you elaborate? Is it easy to migrate?

[reliq]

Hmmm. What's happening here is interesting... 👀

[cwilby]

@aglipanci sorry I should have been more clear - I'm starting a new project without existing records.

If you are already using the Auditing package, migrating will be tricky as the new library digitally signs ledger entries.

Edit: more here https://gitlab.com/altek/accountant/-/issues/26

[icaroscherma]

Guys, only the Maintainers can approve this. If you are "desperate" to use L7 with this package, use @efriandika solution. Add this to your composer.json :

"repositories": [
    {
        "type": "git",
        "url": "https://github.com/RossAHC/laravel-auditing"
    }
],
"require": {
    "owen-it/laravel-auditing": "dev-laravel-7"
},

[aaly00]

LGTM

[mpyw]

What's blocking it?

[icaroscherma]

What's blocking it?

Merging is blocked means that it's open-sorce but not free-software.
Merging will not be automatic after CI's approval, it relies on the Mainatainer's (human) approval.
Since none of us (so far) it's an Official Maintainer of this repository, we have no power here.

[mpyw]

@icaroscherma Sure, I know. My question is "Why the maintainers are pending this PR?"

[icaroscherma]

@icaroscherma Sure, I know. My question is "Why the maintainers are pending this PR?"

This is a good question, since he's commiting non-stop. (He already had 11 commits today)

@anteriovieira Aprova o PR aqui jovem =(

[backstageel]

[aaly00]

Any updates?

[RossAHC]

@anteriovieira Is there anything specific that needs to be changed with this PR for it to be approved? If it's because CI checks haven't been reported it might mean there's a need to remove the outdated check in the protected branch settings in the repository settings.

[icaroscherma]

@anteriovieira Is there anything specific that needs to be changed with this PR for it to be approved? If it's because CI checks haven't been reported it might mean there's a need to remove the outdated check in the protected branch settings in the repository settings.

I've emailed him yesterday and I got no replies so far. :/
But IMHO, I don't think it's an issue with your PR.

[garbinmarcelo]

Teria alguma previsão para o suporte ao Laravel 7? 😃 🍻

---

Would you have an estimated date for Laravel 7 support?

[mpyw]

@anteriovieira If you are busy, why don't you recruit maintainers from contributors?

[cwilby]

@mpyw I'm not sure "busy" is accurate, maybe a dusty notifications icon?

[mpyw]

@cwilby I see. Anyway, if the author abandon maintaining, it's just a matter of time that a fork will be registered to Packagist...

[mpyw]

@RossAHC Would you consider registering to Packagist if the PR will have been stale for several weeks from now?

[efriandika]

I agree with @cwilby ..
Probably we can contact to @anteriovieira email directly wether he has a posibility to merge this PR or no. If no, we can go ahead creating a new organization to maintain this one...
I think this library is amazing, we should make this keep alive.

[cwilby]

@efriandika The concern there is creating another fork of the same project. This has been an issue since the original maintainer (@quetzyg) forked this project and made Accountant - which has gained from refactoring this project.

Additionally, there is progress on a migration script to convert this package.

That being said, would be great to have this branch merged 🤓

[MrReeds]

I wrote him email on 14th, no reply. Mentioned that maybe he could add maintainers if he is too busy

[jtomek]

I just wrote him on LinkedIn.

[anteriovieira]

Guys I'm sorry about that. I will go back to work on the package again.