♻️ doc types first pass #994
Conversation
willpower232
force-pushed
the
doc-types-first-pass
branch
from
7e8b987 to
0a99ae0
Compare
|
spoiler alert php 7 doesn't support this so would have to wait for v14 I guess
|
src/Audit.php
Outdated
| */ | ||
| public function getTags(): array | ||
| public function getTags() |
There was a problem hiding this comment.
Why not ?:
return preg_split('/,/', $this->tags, -1, PREG_SPLIT_NO_EMPTY) ?: [];There was a problem hiding this comment.
personally I would rather allow the user to detect failure since there could be a big problem with whatever the user is trying to do and covering it up with an empty array would effectively silence any issue unless the user is paying close attention to their output.
could always check for the false and throw an exception I guess which would be a bit clearer to the user than the type error which would probably happen currently.
There was a problem hiding this comment.
But within this context that should not happen(no problems reported), because those tags come from the database, where the audit was saved, and correctly formatted, am I wrong?
This is just a change to make phpstan happy in my opinion, I think we should avoid complicating things for developers.
It seems to me that it is changing the signature unnecessarily
There was a problem hiding this comment.
Oh yeah absolutely, phpstan is quite brutal. I've just got a lot of years of not trusting anyone haha.
I'll simplify it 🙏
erikn69
force-pushed
the
doc-types-first-pass
branch
from
0a99ae0 to
011fb8c
Compare
A first pass of doc types, referencing the v14 branch as well as phpstan level 8, removing duplicated types and adding missing types.
I'm hoping this is basic enough to not cause any issues.