Skip to content

renamed vendor/_nut to internal (re #11)#15

Open
dvirsky wants to merge 1 commit intoowenthereal:masterfrom
EverythingMe:internal
Open

renamed vendor/_nut to internal (re #11)#15
dvirsky wants to merge 1 commit intoowenthereal:masterfrom
EverythingMe:internal

Conversation

@dvirsky
Copy link
Copy Markdown

@dvirsky dvirsky commented Mar 8, 2015

Signed-off-by: Dvir Volk dvirsky@gmail.com

Signed-off-by: Dvir Volk <dvirsky@gmail.com>
@bradrydzewski
Copy link
Copy Markdown

+1

@owenthereal
Copy link
Copy Markdown
Owner

Sorry for the late reply. We'd need to remove all test files as well. Previously dependencies are vendored in a folder starting with "_" and Go ignores running tests in such folder (e.g., go test ./...). But with the new folder "internal", Go won't ignore running tests from dependencies. Details see #11 (comment).

@lithammer
Copy link
Copy Markdown

We'd need to remove all test files as well.

I think there should at least be an option to opt-in/out of that, because I actually think it's a feature to run the tests for all vendored dependencies as well. Then you know your whole dependency chain is ok.

@owenthereal
Copy link
Copy Markdown
Owner

@Renstrom Sure, I thought about this too. We could add build tags grouped by dependencies. For example, for dependency foo, we add:

// +build foo

Then you could run go test ./... -tags foo to run tests for dependency foo. But let's do that one step at a time. I bet most people wouldn't need to vendor tests of dependencies.

@lithammer
Copy link
Copy Markdown

That sounds like a good approach to me, didn't know about build tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants