renamed vendor/_nut to internal (re #11)#15
renamed vendor/_nut to internal (re #11)#15dvirsky wants to merge 1 commit intoowenthereal:masterfrom
Conversation
Signed-off-by: Dvir Volk <dvirsky@gmail.com>
|
+1 |
|
Sorry for the late reply. We'd need to remove all test files as well. Previously dependencies are vendored in a folder starting with "_" and Go ignores running tests in such folder (e.g., |
I think there should at least be an option to opt-in/out of that, because I actually think it's a feature to run the tests for all vendored dependencies as well. Then you know your whole dependency chain is ok. |
|
@Renstrom Sure, I thought about this too. We could add build tags grouped by dependencies. For example, for dependency foo, we add: // +build fooThen you could run |
|
That sounds like a good approach to me, didn't know about build tags. |
Signed-off-by: Dvir Volk dvirsky@gmail.com