Skip to content

Added SourceID support throughout platforms (marshals to sqlite3_sourceid API) #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2015

Conversation

thornley-touchstar
Copy link

Sorry, unable to test across all platforms (no IOS Xamarin license) and upgrade Windows for RT, etc.

Android/Win32/Generic are working fine.

@oysteinkrog
Copy link
Owner

Thanks:)

oysteinkrog added a commit that referenced this pull request May 13, 2015
Added SourceID support throughout platforms (marshals to sqlite3_sourceid API)
@oysteinkrog oysteinkrog merged commit 3231d2d into oysteinkrog:master May 13, 2015
@thornley-touchstar
Copy link
Author

No problems! I have more changes coming soon (linq expression improvements, etc)…

One quick question for you, is it better to issue a pull request on a dedicated branch containing my changes, as opposed to issuing it on master?

I noticed in this case it was fortuitous as I had to fix a mistake (and corrected the DllName references in the original code), however in most cases the pull request should be targeting a specific set of changes.

Thanks for absorbing my changes ☺

Regards,

David.

From: Øystein Krog [mailto:[email protected]]
Sent: Thursday, 14 May 2015 12:56 AM
To: oysteinkrog/SQLite.Net-PCL
Cc: David Thornley
Subject: Re: [SQLite.Net-PCL] Added SourceID support throughout platforms (marshals to sqlite3_sourceid API) (#172)

Thanks:)


Reply to this email directly or view it on GitHubhttps://github.com//pull/172#issuecomment-101702297.

@oysteinkrog
Copy link
Owner

It is indeed better to create the PR from a dedicated branch:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants