Adds (optional) ctor parameters from SQLiteConnection to SQLiteConnectionWithLock #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionWithLock. SQLiteConnectionWithLock was missing a way to setup tableMappings and extraTypeMappings while the base class SQLiteConnection was accepting these values as constructor parameters.
|
+1 – I would really appreciate that. |
|
Thanks:) |
oysteinkrog
added a commit
that referenced
this pull request
May 13, 2015
Adds (optional) ctor parameters from SQLiteConnection to SQLiteConnectionWithLock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLiteConnectionWithLock was missing a way to setup tableMappings and extraTypeMappings while the base class SQLiteConnection was accepting these values as constructor parameters.
For some special use cases we are planning to provide custom tableMappings. This works fine on SQLiteConnection but there was no way to use the same stuff on SQLiteConnectionWithLock. That was most surprising since SQLiteConnectionWithLock inherits from SQLiteConnection.