Issue #273: Added bounds checking in order to correctly model packet_in.extract() semantics for header stacks.#307
Open
Hardikoder wants to merge 1 commit intop4lang:mainfrom
Open
Issue #273: Added bounds checking in order to correctly model packet_in.extract() semantics for header stacks.#307Hardikoder wants to merge 1 commit intop4lang:mainfrom
Hardikoder wants to merge 1 commit intop4lang:mainfrom
Conversation
…ment operation for fixed size header stacks. It prevents out-of bounds memory access by verifying if the current index is within the valid bounds before accessing the next header stack element. Signed-of-by: Hardik Bhagia <hardikbhagia@gmail.com> Signed-off-by: Hardik <hardikbhagia@gmail.com>
asl
requested changes
Jan 27, 2026
| #include "mlir/Interfaces/FunctionInterfaces.h" | ||
| #include "mlir/Pass/Pass.h" | ||
| #include "mlir/Transforms/DialectConversion.h" | ||
| #include "mlir/Dialect/Arith/IR/Arith.h" |
Collaborator
There was a problem hiding this comment.
We are not using arith dialect here. You're also lacking any tests
Collaborator
|
@Hardikoder Are you going to continue working on this fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #273 : Added a bounds checking verify operation and increment operation for fixed size header stacks. It prevents out-of bounds memory access by verifying if the current index is within the valid bounds before accessing the next header stack element.
Signed-off-by: HardikBhardikbhagia@gmail.com