P4HIR: Add verifySymbolUses for TableActionOp#318
Open
Lavanya-Malakalapalli wants to merge 1 commit intop4lang:mainfrom
Open
P4HIR: Add verifySymbolUses for TableActionOp#318Lavanya-Malakalapalli wants to merge 1 commit intop4lang:mainfrom
Lavanya-Malakalapalli wants to merge 1 commit intop4lang:mainfrom
Conversation
Signed-off-by: Lavanyampalli <lavanyampalli@gmail.com>
Lavanya-Malakalapalli
force-pushed
the
table-action-symbol-uses
branch
from
69b318d to
c41fce7
Compare
asl
reviewed
Feb 23, 2026
| if (!actionAttr) | ||
| return emitOpError("requires an 'action' symbol reference attribute"); | ||
|
|
||
| // The action attribute is the control-plane name. After inlining it may |
Collaborator
There was a problem hiding this comment.
We should never inline action calls into table_action op. This is merely a marker. So, if this happens, then we do have the problem elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TableActionOp had SymbolUserOpInterface commented out, which meant
the DCE pass had no way to see that a table_actions block was
referencing an action. So even live actions were getting dropped.
Uncommented the interface and added verifySymbolUses(). The tricky
part was figuring out why the InlineControls tests broke -- turns out
After inlining, the action= attribute still holds the original short
name (@A1), but the FuncOp itself got renamed to something like
@d::@cinst2.a1. So looking it up hard-fails post-inlining.
Made the check soft -- if the symbol resolves, we validate it; if not
we just skip it. At that point, the action= attr is really just a
control-plane label anyway.
All 169 tests passed.
