Skip to content

Try to be even more aggressive in disabled llvm build targets.#325

Open
fruffy wants to merge 2 commits intomainfrom
fruffy/build_fix
Open

Try to be even more aggressive in disabled llvm build targets.#325
fruffy wants to merge 2 commits intomainfrom
fruffy/build_fix

Conversation

@fruffy
Copy link
Copy Markdown
Collaborator

@fruffy fruffy commented Mar 6, 2026

Just checking what can be done.

@asl
Copy link
Copy Markdown
Collaborator

asl commented Mar 6, 2026

@fruffy This still takes cached LLVM build...

@fruffy
Copy link
Copy Markdown
Collaborator Author

fruffy commented Mar 6, 2026

@fruffy This still takes cached LLVM build...

I am a little confused why, isn't this hashed based on the script

fi
CMAKE_FLAGS+=" -DLLVM_CCACHE_BUILD=ON"
# Disable all LLVM machine-code backends
CMAKE_FLAGS+=" -DLLVM_TARGETS_TO_BUILD=\"\""
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot disable all backends. Can use host or native here.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah was worth a shot, I see lots of unrelated stuff being built and was hoping to get rid of that

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we want host or native?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this seems to be a sensible default for a single target to build. I doubt you'd want to stick to, say, x86 or aarch64.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a shell option to pass any additional targets, if downstream back ends need those?

@fruffy fruffy force-pushed the fruffy/build_fix branch from 3928c63 to 9947bf7 Compare March 6, 2026 22:52
Signed-off-by: fruffy <fruffy@nyu.edu>
@fruffy fruffy force-pushed the fruffy/build_fix branch from 9947bf7 to 172b3d8 Compare March 7, 2026 16:52
@fruffy fruffy marked this pull request as ready for review March 7, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants