Skip to content

Conversation

@michael-todorovic
Copy link
Contributor

This PR returns rc=2 for unsupported commands.
Before, if you override the args for a component with a mistake, it happily returned 0. This can be misleading once in k8s, especially on the runner part which shown a Completed status whereas it totally crashed.

Now this returns a different rc and an error:

╰ go build -o bin/burrito main.go && bin/burrito server unsupportedcommand ; echo $?
Error: unknown server subcommand: unsupportedcommand
Run 'burrito server --help' for usagecmd to use burrito's server

Usage:
  burrito server [flags]
  burrito server [command]

Available Commands:
  start       Start burrito's server

Flags:
  -h, --help   help for server

Use "burrito server [command] --help" for more information about a command.
2

@github-project-automation github-project-automation bot moved this to 📋 Backlog in burrito May 14, 2025
@corrieriluca corrieriluca moved this from 📋 Backlog to 👀 In review in burrito May 16, 2025
@LucasMrqes LucasMrqes force-pushed the fix/unsupportedCommand branch from defe7a3 to 14fad95 Compare May 16, 2025 12:50
LucasMrqes
LucasMrqes previously approved these changes May 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 44.98%. Comparing base (235a7e0) to head (0f6d27c).

Files with missing lines Patch % Lines
internal/utils/cmd/cmd.go 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   45.06%   44.98%   -0.08%     
==========================================
  Files          79       79              
  Lines        5743     5753      +10     
==========================================
  Hits         2588     2588              
- Misses       2940     2950      +10     
  Partials      215      215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LucasMrqes LucasMrqes force-pushed the fix/unsupportedCommand branch from df4ee9f to 0f6d27c Compare May 16, 2025 13:22
@LucasMrqes LucasMrqes merged commit 1a614f3 into padok-team:main May 16, 2025
5 of 7 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in burrito May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants