Skip to content

Conversation

@arnaud-dezandee
Copy link
Contributor

Fix #598

Changes made:

  • Replaced terraform-exec library: Migrated from hashicorp/terraform-exec to direct os/exec commands
  • Created shared base: New internal/runner/tools/base/base.go with BaseTool struct containing all common functionality

@corrieriluca corrieriluca moved this to 👀 In review in burrito Jun 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 61.90476% with 24 lines in your changes missing coverage. Please review.

Project coverage is 48.94%. Comparing base (cd78aec) to head (f6369aa).

Files with missing lines Patch % Lines
internal/runner/tools/base/base.go 65.30% 11 Missing and 6 partials ⚠️
internal/runner/tools/opentofu/opentofu.go 0.00% 6 Missing ⚠️
internal/runner/tools/install.go 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   48.48%   48.94%   +0.46%     
==========================================
  Files          80       81       +1     
  Lines        5924     5874      -50     
==========================================
+ Hits         2872     2875       +3     
+ Misses       2820     2769      -51     
+ Partials      232      230       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@corrieriluca
Copy link
Member

corrieriluca commented Jun 27, 2025

When I read the output of the Unit tests job I don't see any tests ran in the runner package 🤔

That's strange, because we have tests in this area, I'm gonna check locally before merging.

	github.com/padok-team/burrito/internal/runner/tools		coverage: 0.0% of statements
	github.com/padok-team/burrito/internal/runner/tools/base		coverage: 0.0% of statements
	github.com/padok-team/burrito/internal/runner/tools/opentofu		coverage: 0.0% of statements
	github.com/padok-team/burrito/internal/runner/tools/terraform		coverage: 0.0% of statements
	github.com/padok-team/burrito/internal/runner/tools/terragrunt		coverage: 0.0% of statements

Edit: Actually it's okay, tests are associated with the runner package:

ok  	github.com/padok-team/burrito/internal/runner	16.720s	coverage: 64.4% of statements

@corrieriluca
Copy link
Member

Nevertheless, thanks for your great contribution! 🚀

@corrieriluca corrieriluca merged commit 96d5e53 into padok-team:main Jun 29, 2025
5 of 7 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in burrito Jun 29, 2025
@arnaud-dezandee arnaud-dezandee deleted the fix/remove-tf-exec branch July 1, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Setting env var for TF_WORKSPACE isn't working?

3 participants