feat: allow control of CRDs installation #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Todorovic <[email protected]>
Signed-off-by: Michael Todorovic <[email protected]>
corrieriluca
approved these changes
Sep 5, 2025
Member
corrieriluca
left a comment
corrieriluca
left a comment
There was a problem hiding this comment.
LGTM! Thanks @michael-todorovic it works better than the previous solution and will allow CRD evolution 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #663. After googling for alternatives, I keep CRDs inside the
templatesfolder as this allows easier CRDs upgrades, without needing a separate chart yet.Helm can't read the filesystem and CRDs are autogenerated so I copy manifests thanks to Makefile, adding the conditional at the same time. By default, the PR keeps CRDs management enabled.
This PR is part of a bigger work to allow multi-instances of Burrito on the same k8s cluster. RBAC installation control is next, then a code update will land as well. It's easier to review this way :)