GH1174 more precise kwargs in DataFrame.to_clipboard
#1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Apr 22, 2025
Collaborator
Dr-Irv
left a comment
Dr-Irv
left a comment
There was a problem hiding this comment.
If you want to copy the arguments from to_csv(), use what is in frame.pyi, not what is in the source code.
Also, add tests for some of the to_csv() arguments with to_clipboard(), in test_io.py:test_clipboard()
Dr-Irv
requested changes
Apr 22, 2025
Collaborator
Dr-Irv
left a comment
Dr-Irv
left a comment
There was a problem hiding this comment.
If you want to copy the arguments from to_csv(), use what is in generic.pyi, not what is in the source code.
Also, add tests for some of the to_csv() arguments with to_clipboard(), in test_io.py:test_clipboard()
I think it would be better to delete to_clipboard() from frame.pyi and series.pyi and just create the single definition in generic.pyi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR types the keyword parameters in DataFrame.to_clipboard according to to_csv
kwargsinDataFrame.to_clipboardaccording toto_csv#1174assert_type()to assert the type of any return value