Skip to content

API: nlargest/nsmallest, take_last -> keep #10792

@jreback

Description

@jreback
Contributor

nlargest/nsmallest on frame should have take_last -> keep, in-line with #10236

here

no deprecation is necessary as this is new in 0.17.0

cc @sinhrks
cc @cpcloud

Activity

added this to the 0.17.0 milestone on Aug 10, 2015
sinhrks

sinhrks commented on Aug 11, 2015

@sinhrks
Member

Do we need an option to keep all elements in this case, keep='all' or keep=True?

And Series.nlargest/nsmallest need deprecation.

jreback

jreback commented on Aug 11, 2015

@jreback
ContributorAuthor

you don't need to keep all option (that would be just sort :)

so just a direct keyword replacement for Series

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    API DesignReshapingConcat, Merge/Join, Stack/Unstack, Explode

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jreback@sinhrks

        Issue actions

          API: nlargest/nsmallest, take_last -> keep · Issue #10792 · pandas-dev/pandas