`nlargest/nsmallest` on frame should have `take_last` -> `keep`, in-line with #10236 [here](https://github.com/pydata/pandas/blob/master/pandas/core/frame.py#3187) no deprecation is necessary as this is new in 0.17.0 cc @sinhrks cc @cpcloud
Activity
sinhrks commentedon Aug 11, 2015
Do we need an option to keep all elements in this case,
keep='all'
orkeep=True
?And
Series.nlargest/nsmallest
need deprecation.jreback commentedon Aug 11, 2015
you don't need to keep all option (that would be just sort :)
so just a direct keyword replacement for Series
Drop take_last kwarg from method signatures
Drop take_last kwarg from method signatures
Drop take_last kwarg from method signatures
MAINT: Drop take_last kwarg from method signatures
MAINT: Drop take_last kwarg from method signatures
MAINT: Drop take_last kwarg from method signatures
MAINT: Drop take_last kwarg from method signatures
MAINT: Drop take_last kwarg from method signatures
MAINT: Drop take_last kwarg from method signatures
MAINT: Drop take_last kwarg from method signatures
MAINT: Drop take_last kwarg from method signatures
MAINT: Drop take_last kwarg from method signatures