Skip to content

Explicit signature for NDFrame.to_hdf #20903

@TomAugspurger

Description

@TomAugspurger
Contributor

Currently we have to_hdf(self, path_or_buf, key, **kwargs)

It'd be good to replace that with the actual signature (unless I'm missing a reason for the current implementation) and document it fully.

Activity

added this to the Next Major Release milestone on May 1, 2018
abi-aryan

abi-aryan commented on May 14, 2018

@abi-aryan

I would love to help. How can I get started on this?

TomAugspurger

TomAugspurger commented on May 14, 2018

@TomAugspurger
ContributorAuthor

Great! General contributing guidelines are at http://pandas-docs.github.io/pandas-docs-travis/contributing.html

For this specific one, I would look at to_hdf in pandas/pandas/io/pytables.py. Anywhere we pass kwargs currently (store.append and store.put) we'll need to figure out the correct set of keyword arguments expected. Some like mode, format, etc. will be straightforward. Others will take some digging. Let us know if you get stuck.

abi-aryan

abi-aryan commented on May 14, 2018

@abi-aryan

Cool. On it now.

jbrockmendel

jbrockmendel commented on Dec 4, 2019

@jbrockmendel
Member

Closed by #29957.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @TomAugspurger@abi-aryan@jbrockmendel

        Issue actions

          Explicit signature for NDFrame.to_hdf · Issue #20903 · pandas-dev/pandas