Closed
Description
Working on a PeriodArray. For the first thing I tried, Series.combine
doesn't work.
In
Lines 2324 to 2330 in 7343fd3
ValueError
since the freq can't be inferred.
I think that should be except Exception
instead. Thoughts @Dr-Irv?
Metadata
Metadata
Assignees
Type
Projects
Relationships
Development
No branches or pull requests
Activity
jorisvandenbossche commentedon Sep 27, 2018
Yes, I think that can be broadened to general exception.
Dr-Irv commentedon Sep 27, 2018
IMHO, I would just add the errors that you know that could occur. So if
ValueError
can be raised by._from_sequence()
, then I think you should doexcept TypeError, ValueError
. If some other error is raised, then it might catch another issue in someone's code.TomAugspurger commentedon Sep 27, 2018
Closes pandas-dev#22850
Squashed commit of the following:
REF: Make PeriodArray an ExtensionArray (#22862)
REF: Make PeriodArray an ExtensionArray (pandas-dev#22862)
REF: Make PeriodArray an ExtensionArray (pandas-dev#22862)
REF: Make PeriodArray an ExtensionArray (pandas-dev#22862)