Skip to content

DEPR: deprecate pandas/io/date_converters.py #24518

@mroeschke

Description

@mroeschke
Member

This file contains one function that is used elsewhere in the code base (that can be moved), and the rest is unused and not advertised in the api.

Raising this issue to gauge whether we should outright remove it or deprecate this file since its technically public in io

Activity

jreback

jreback commented on Jan 1, 2019

@jreback
Contributor

yeah let's do it. I also think you can just remove the generic_parser branch entirely (meaning just fully deprecate this), I think to_datetime handles all of these cases

added
DatetimeDatetime data dtype
IO CSVread_csv, to_csv
DeprecateFunctionality to remove in pandas
on Jan 1, 2019
jorisvandenbossche

jorisvandenbossche commented on Jan 3, 2019

@jorisvandenbossche
Member

Yes, I think the original idea behind this was to have functions that could be passed to read_csv's date_parser function. But there are much better ways to do that (to_datetime, or a way to provide a date format in read_csv that is discussed elsewhere).
So happy to see it deprecated

jbrockmendel

jbrockmendel commented on Dec 10, 2019

@jbrockmendel
Member

definitely go for it.

added this to the Contributions Welcome milestone on Dec 11, 2019
jbrockmendel

jbrockmendel commented on Dec 20, 2019

@jbrockmendel
Member

Is any of this user-facing (i.e.need deprecation cycle) or can we just rip it out?

mroeschke

mroeschke commented on Dec 20, 2019

@mroeschke
MemberAuthor

The conservative thing to do is go through a deprecation cycle, but since this is not advertised anywhere ripping it out might be okay.

jorisvandenbossche

jorisvandenbossche commented on Dec 21, 2019

@jorisvandenbossche
Member

This is documented (https://dev.pandas.io/docs/user_guide/io.html#date-parsing-functions), so certainly needs to be deprecated first I think

changed the title [-]Remove/Deprecate(?) pandas/io/date_converters.py[/-] [+]DEPR: deprecate pandas/io/date_converters.py[/+] on Dec 21, 2019
avinashpancham

avinashpancham commented on Aug 9, 2020

@avinashpancham
Contributor

take

modified the milestones: Contributions Welcome, 1.2 on Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Relationships

None yet

    Development

    Participants

    @jreback@jorisvandenbossche@jbrockmendel@mroeschke@avinashpancham

    Issue actions

      DEPR: deprecate pandas/io/date_converters.py · Issue #24518 · pandas-dev/pandas