-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Closed
Labels
DatetimeDatetime data dtypeDatetime data dtypeDeprecateFunctionality to remove in pandasFunctionality to remove in pandasIO CSVread_csv, to_csvread_csv, to_csvgood first issue
Milestone
Description
This file contains one function that is used elsewhere in the code base (that can be moved), and the rest is unused and not advertised in the api.
Raising this issue to gauge whether we should outright remove it or deprecate this file since its technically public in io
gfyoung and jorisvandenbossche
Metadata
Metadata
Assignees
Labels
DatetimeDatetime data dtypeDatetime data dtypeDeprecateFunctionality to remove in pandasFunctionality to remove in pandasIO CSVread_csv, to_csvread_csv, to_csvgood first issue
Type
Projects
Relationships
Development
Select code repository
Activity
jreback commentedon Jan 1, 2019
yeah let's do it. I also think you can just remove the
generic_parser
branch entirely (meaning just fully deprecate this), I thinkto_datetime
handles all of these casesjorisvandenbossche commentedon Jan 3, 2019
Yes, I think the original idea behind this was to have functions that could be passed to
read_csv
'sdate_parser
function. But there are much better ways to do that (to_datetime
, or a way to provide a date format inread_csv
that is discussed elsewhere).So happy to see it deprecated
jbrockmendel commentedon Dec 10, 2019
definitely go for it.
jbrockmendel commentedon Dec 20, 2019
Is any of this user-facing (i.e.need deprecation cycle) or can we just rip it out?
mroeschke commentedon Dec 20, 2019
The conservative thing to do is go through a deprecation cycle, but since this is not advertised anywhere ripping it out might be okay.
jorisvandenbossche commentedon Dec 21, 2019
This is documented (https://dev.pandas.io/docs/user_guide/io.html#date-parsing-functions), so certainly needs to be deprecated first I think
[-]Remove/Deprecate(?) pandas/io/date_converters.py[/-][+]DEPR: deprecate pandas/io/date_converters.py[/+]avinashpancham commentedon Aug 9, 2020
take