Skip to content

groupby.agg should refuse non-aggregation operations #26743

Closed
@ghost

Description

Since groupby.agg() is, "by definition a reducer." (in other words, produces one value per series in a group), it seems odd that it accepts non-aggregating operations such as 'rank':

Related to #22509 (comment) where groupby.transform('rank') applies the wrong code path to 'rank'
because it is treated as an aggregator (array->scalar) instead of a shape-preserving operation.

In [82]: df=pd.DataFrame(dict(price=[1,2,2,3,3,3],cost=(1,2,1,3,2,1)))
    ...: df
Out[82]: 
   price  cost
0      1     1
1      2     2
2      2     1
3      3     3
4      3     2
5      3     1

In [83]: g=df.groupby('price')
    ...: g.agg('rank').astype(int)
Out[83]: 
   cost
0     1
1     2
2     1
3     3
4     2
5     1```

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        No participants

        Issue actions

          groupby.agg should refuse non-aggregation operations · Issue #26743 · pandas-dev/pandas