Skip to content

VIS: register_matplotlib_converters is exposed through plotting backend #27152

Open
@jorisvandenbossche

Description

@jorisvandenbossche
Member

With the recent plotting backend refactor, the pandas.plotting.register_matplotlib_converters is now referring to the "general" register which calls the plotting backend, instead of just being the matplotlib register function.

It probably doesn't make much sense to expose this through the plotting backend?
It is maybe done for consistency (everything goes through the plotting backend, also internally), but personally I found this indirection confusing when looking at the source code (for this case).

cc @datapythonista

Activity

datapythonista

datapythonista commented on Jul 4, 2019

@datapythonista
Member

I agree, more than for consistency was done to be able to fully split the matplotlib code into a separate module (without doing too many tricky things).

I'm unsure whether registering converters is useful for any backend, and it may makes sense to simply change the name of the function. Or if users should call the function directly from the backend (the backend is currently private pandas.plotting._matplotlib, so this would probably require making it public).

This is being discussed in #26747

jorisvandenbossche

jorisvandenbossche commented on Jul 6, 2019

@jorisvandenbossche
MemberAuthor

I personally don't think it makes sense for backends to have this (and if they have something similar, I don't think it should necessarily be exposed through pandas).

I wouldn't move the public API, the public name already has "matplotlib" in it, so it is rather clear it is for the matplotlib backend.

added this to the 0.25.0 milestone on Jul 6, 2019
removed this from the 0.25.0 milestone on Jul 18, 2019
added
InternalsRelated to non-user accessible pandas implementation
on Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    InternalsRelated to non-user accessible pandas implementationNeeds DiscussionRequires discussion from core team before further actionVisualizationplotting

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @WillAyd@jorisvandenbossche@datapythonista@mroeschke

        Issue actions

          VIS: register_matplotlib_converters is exposed through plotting backend · Issue #27152 · pandas-dev/pandas