Closed
Description
Looking at #31929, we can fix the specific case there, but there is a long tail of mixed-and-match positional/keyword arguments that will still be fragile. These will be easier to deal with if more of them are keyword-only, in particular unit
, maybe nanosecond
.
Activity
mroeschke commentedon Jan 11, 2022
+1, making nanosecond keyword only would fix #32526
I wouldn't mind for deprecating epoch ints + unit or strings inputs entirely in favor of
pd.to_datetime
jbrockmendel commentedon Jan 11, 2022
seems reasonable
Hard part is doing the deprecation without a giant perf hit. i.e. i dont think we can use the deprecate_nonkeyword_arguments decorator here. https://groups.google.com/g/cython-users/c/KQ4WwXWCXBA suggests there isn't an easy way to do this in cython.
mroeschke commentedon Jan 11, 2022
Maybe this is a candidate for a 2.0 break then? #44823