Skip to content

Unused (and undocumented) kind parameter in read_excel #4712

@jtratner

Description

@jtratner
Contributor

closes #4563

Why does read_excel take a kind parameter at all? It gets passed to the ExcelFile constructor, set on the object and then (as far as I can tell) never gets used for anything.

This should either be removed from the signature (which doesn't affect anything, because it will be accepted into kwds anyways) or added into the docs and then actually used for something.

if we remove it, just need to add a:

# Remove this branch in 0.14
if 'kind' in kwargs:
   warnings.warn("Kind is deprecated and will be removed in a future version of pandas")
   kwargs.pop('kind')

Was not previously being used for anything anyways.

Activity

jtratner

jtratner commented on Aug 30, 2013

@jtratner
ContributorAuthor

also needs to be removed from the ExcelFile constructor in io/parsers along with guard.

cancan101

cancan101 commented on Aug 31, 2013

@cancan101
Contributor

Also will close #4563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    API DesignIO DataIO issues that don't fit into a more specific label

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Participants

      @cancan101@jtratner

      Issue actions

        Unused (and undocumented) `kind` parameter in `read_excel` · Issue #4712 · pandas-dev/pandas