You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Good catch. Agreed _cmp_method should be changed to return "boolean[pyarrow]" instead of "Boolean" type. Since ArrowStringArray and ArrowExtensionArray are both marked as experimental it should be okay to change it for 2.0 if you're interested.
Activity
lukemanley commentedon Feb 23, 2023
Maybe somewhat related - do you think the
ArrowExtensionArray
comparison methods should preserve the pyarrow type and returnboolean[pyarrow]
?mroeschke commentedon Feb 23, 2023
Good catch. Agreed
_cmp_method
should be changed to return"boolean[pyarrow]"
instead of"Boolean"
type. SinceArrowStringArray
andArrowExtensionArray
are both marked as experimental it should be okay to change it for 2.0 if you're interested.lukemanley commentedon Feb 24, 2023
Sounds good. I'll take a look