Skip to content

BUG: MultiIndex not dropping nan level and invalid code value #26408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 1, 2019
Merged

BUG: MultiIndex not dropping nan level and invalid code value #26408

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e0d3bb4
BUG: MultiIndex not dropping nan level and invalid code value
May 15, 2019
af2ad91
update whatsnew statement
May 16, 2019
248177b
vectorise reassignment of na codes
May 16, 2019
b6d29bd
remove redundant boundary check
May 16, 2019
041b4cd
refactor validate code and add tests for set_code and set_level
May 17, 2019
933615b
move multiIndex bug to api breaking changes
May 20, 2019
d4227c6
refactor validate codes and add in doc-strings
May 20, 2019
b66d3a4
update whatsnew record
May 21, 2019
81ebfda
add ensure frozen for codes
May 21, 2019
7dfd698
update whatsnew code display
May 21, 2019
ec265fa
update whatsnew codeblocks
May 22, 2019
af35fa3
shorten lines for whatsnew
May 23, 2019
6ec67b3
remove shallow copy and update function descirptor
May 27, 2019
28c953f
remove redundant validation of code
May 29, 2019
055999d
add explanatory comments and add type annotation
May 29, 2019
d9db853
add test for verify _integrity=False
May 29, 2019
a141e40
add dropna tests
May 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions doc/source/whatsnew/v0.25.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,18 +97,18 @@ would be reassigned as -1. (:issue:`19387`)

.. code-block:: ipython

MultiIndex(levels=[[nan, None, NaT, 128, 2]],
codes=[[0, -1, 1, 2, 3, 4]])
MultiIndex(levels=[[1, 2]],
codes=[[0, -2]])
Out[1]: MultiIndex(levels=[[nan, None, NaT, 128, 2]],
codes=[[0, -1, 1, 2, 3, 4]])
Out[2]: MultiIndex(levels=[[1, 2]],
codes=[[0, -2]])

*New Behavior*:

.. ipython:: python
.. ipython:: ipython

MultiIndex(levels=[[nan, None, NaT, 128, 2]],
Out[1]: MultiIndex(levels=[[nan, None, NaT, 128, 2]],
codes=[[-1, -1, -1, -1, 3, 4]])
ValueError: On level 0, code value (-2) < -1
Out[2]: ValueError: On level 0, code value (-2) < -1


.. _whatsnew_0250.api_breaking.groupby_apply_first_group_once:
Expand Down