BUG: GroupBy.value_counts sorting order #56016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Bug
Groupby
Algos
mroeschke
reviewed
Nov 17, 2023
| @pytest.mark.parametrize("normalize", [True, False]) | ||
| def test_value_counts_sort(sort, vc_sort, normalize): | ||
| # GH#55951 | ||
| df = DataFrame({"a": [2, 1, 1, 1], 0: [3, 4, 3, 3]}) |
Member
There was a problem hiding this comment.
Could you also tests with Categorical?
Member
Author
There was a problem hiding this comment.
Thanks - good call. I added a test and found a bug calling .sortlevel() in the categorical section. But the categorical behavior is still buggy here; namely
pandas/pandas/core/groupby/groupby.py
Lines 2824 to 2826 in ef2c61a
is constructing the index by taking the cartesian product across all groupings; it should only be doing this for the categorical variables. That's not an easy fix, but will be handled in #55738 where we can just remove that whole block of code.
mroeschke
approved these changes
Nov 17, 2023
Member
|
Thanks @rhshadrach |
This was referenced Nov 17, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.