Skip to content

Remove pandas.core.groupby.DataFrameGroupBy for describe, idxmax, idxmin, value_counts from ci/code_checks.sh #56828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 2 commits into from
Jan 11, 2024
Merged

Remove pandas.core.groupby.DataFrameGroupBy for describe, idxmax, idxmin, value_counts from ci/code_checks.sh #56828

mroeschke merged 2 commits into from
Jan 11, 2024

Conversation

@jordan-d-murphy
Copy link
Contributor

@jordan-d-murphy jordan-d-murphy commented Jan 11, 2024

Checked if validation docstrings passes for :

  1. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.core.groupby.DataFrameGroupBy.describe
  2. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.core.groupby.DataFrameGroupBy.idxmax
  3. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.core.groupby.DataFrameGroupBy.idxmin
  4. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.core.groupby.DataFrameGroupBy.value_counts

OUTPUT:

  1. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.core.groupby.DataFrameGroupBy.describe
################################################################################
################################## Validation ##################################
################################################################################

Docstring for "pandas.core.groupby.DataFrameGroupBy.describe" correct. :)
  1. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.core.groupby.DataFrameGroupBy.idxmax
################################################################################
################################## Validation ##################################
################################################################################

Docstring for "pandas.core.groupby.DataFrameGroupBy.idxmax" correct. :)
  1. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.core.groupby.DataFrameGroupBy.idxmin
################################################################################
################################## Validation ##################################
################################################################################

Docstring for "pandas.core.groupby.DataFrameGroupBy.idxmin" correct. :)
  1. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.core.groupby.DataFrameGroupBy.value_counts
################################################################################
################################## Validation ##################################
################################################################################

Docstring for "pandas.core.groupby.DataFrameGroupBy.value_counts" correct. :)

@mroeschke
Copy link
Member

mroeschke commented Jan 11, 2024

Thanks could you resolve the merge conflict?

@mroeschke mroeschke added the Docs label Jan 11, 2024
@jordan-d-murphy
Copy link
Contributor Author

jordan-d-murphy commented Jan 11, 2024 •
edited
Loading

@mroeschke I believe this is fixed now, and the pipeline is running again. Thanks for your help!
Screenshot 2024-01-11 at 12 09 18 PM

@mroeschke mroeschke added this to the 3.0 milestone Jan 11, 2024
@mroeschke mroeschke merged commit 5789f15 into pandas-dev:main Jan 11, 2024
@mroeschke
Copy link
Member

mroeschke commented Jan 11, 2024

Thanks @jordan-d-murphy

@jordan-d-murphy jordan-d-murphy deleted the issue#56804 branch January 12, 2024 04:57
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@jordan-d-murphy @pmhatre1
Remove pandas.core.groupby.DataFrameGroupBy for describe, idxmax, idx…
6cdf6d6 
…min, value_counts from ci/code_checks.sh (pandas-dev#56828)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jordan-d-murphy @mroeschke