DEPR: Enforce deprecation of groupby(...).grouper #57207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # doc/source/whatsnew/v3.0.0.rst
mroeschke
reviewed
Feb 2, 2024
| msg = "DataFrameGroupBy.grouper is deprecated" | ||
| with tm.assert_produces_warning(FutureWarning, match=msg): | ||
| grouper = gb.grouper | ||
| grouper = gb._grouper |
Member
There was a problem hiding this comment.
Are these _grouper usages common internally? If not, I would be OK just removing these tests
Member
Author
There was a problem hiding this comment.
I'm thinking as long as the method exists, we should leave the tests - especially if they aren't computationally intensive. That said, it appears we never use __iter__, so could be removed. I'd like to handle in a follow up. I'll open an issue and list out methods we can remove.
mroeschke
approved these changes
Feb 2, 2024
Member
|
Thanks @rhshadrach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Enforces #56521