Skip to content

[backport 2.3.x] API: ignore empty range/object dtype in Index setop operations (string dtype compat) (#60797) #60948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

(cherry picked from commit ee06e71)

Backport of #60797

Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Mar 21, 2025
@mroeschke mroeschke removed this from the 2.3 milestone Jun 2, 2025
@datapythonista
Copy link
Member

I guess this is not happening. Feel free to reopen if needed.

@jorisvandenbossche
Copy link
Member Author

@mroeschke FWIW best not to remove milestones from backport PRs, because then we will certainly loose track of them .. (or in general please add a comment when doing so, such that it generates a notification, because unfortunately github makes milestone changes silent)

I of course should have updated this a while ago, but ideally this still goes into 2.3.x (assuming there might be some more bugfix release)

@mroeschke
Copy link
Member

Ah sorry about that @jorisvandenbossche. Thanks for the reminder

@mroeschke mroeschke modified the milestones: 2.3, 2.3.1 Jun 8, 2025
@jorisvandenbossche
Copy link
Member Author

There are a bunch of failures in the expression tests, eg pandas/tests/test_expressions.py::TestExpressions::test_run_binary[eq-True-_integer_integers], but that doesn't seem related (and also seeing it on another backport PR)

@jorisvandenbossche
Copy link
Member Author

There are a bunch of failures in the expression tests, eg pandas/tests/test_expressions.py::TestExpressions::test_run_binary[eq-True-_integer_integers], but that doesn't seem related (and also seeing it on another backport PR)

Handling that in #61638

@jorisvandenbossche jorisvandenbossche merged commit 4e20ce1 into pandas-dev:2.3.x Jun 12, 2025
34 of 45 checks passed
@jorisvandenbossche jorisvandenbossche deleted the backport-60797 branch June 12, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants