Update whatsnew for issue #53115 #61586
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
doc/source/whatsnew/v3.0.0.rst
Outdated
| @@ -712,6 +712,7 @@ Timezones | |||
| Numeric | |||
| ^^^^^^^ | |||
| - Bug in :meth:`DataFrame.corr` where numerical precision errors resulted in correlations above ``1.0`` (:issue:`61120`) | |||
| - Bug in :meth:`DataFrame.cov` where presence of ``NaT`` in columns could lead to incorrect results or errors (:issue:`53115`) | |||
There was a problem hiding this comment.
I think it's worth stating that this raises a TypeError now, rather than returning incorrect results. Also IIUC, we always raise a TypeError, regardless of the presence of NaT. So maybe
Suggested change
| - Bug in :meth:`DataFrame.cov` where presence of ``NaT`` in columns could lead to incorrect results or errors (:issue:`53115`) | |
| :meth:`DataFrame.cov` raises a ``TypeError`` instead of returning potentially incorrect results or other errors (:issue:`53115`). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60898