Skip to content

Check lane id of incoming messages #2452

Open
@svyatonik

Description

@svyatonik

slightly related to https://github.com/paritytech/srlabs_findings/issues/142

We shall verify lane of incoming messages - something that we already had before, but lost now. With XCM bridge it means:

  • when we are receiving messages from unsupported lane (e.g. in RBH<>WBH we now only support lane [0, 0, 0, 1] for messages between *mint/*mine chains) - we shall return error from verify_messages_proof if proof contains messages from some other lane. Now this is some static check, but later we'll probably need to maintain map of LaneId => (XcmSource, XcmDestination);
  • @bkontur can we verify that the message is actually sent by the proper source parachain and that it'll be routed to the proper target parachain. For example - when dispatching message that has came by lane [0, 0, 0, 1] to WBH, we want to ensure that it has been actually sent by Rockime2 and is going to Wockmint. Can we do that, or is it handled somewhere already? WDYT about that?

@bkontur @serban300 Can you, guys, please, tackle this?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions