-
Notifications
You must be signed in to change notification settings - Fork 131
Remove unneeded error debug strings #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serban300
so, can we get rid of
skip
andOption
here now? if so, lets clean itor do we use
NotDispatched(None)
somewhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I double checked. The events are stored in an encoded form, so if we do
#[codec(skip)]
, theDispatchBlobError
won't be saved anyway. And it doesn't seem to be used elsewhere. I removed it. PTAL !There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to leave it as:
NotDispatched(Option<DispatchBlobError>)
or
NotDispatched(DispatchBlobError)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, I misunderstood.
NotDispatched(Option<DispatchBlobError>)
andNotDispatched(DispatchBlobError)
don't work. BecauseDispatchBlobError
doesn't implementEncode/Decode
. The only thing we could do here is to deriveEncode, Decode
forDispatchBlobError
in thePolkadot
repo. I can create a PR for that and see if it is accepted. But until then, would it be ok to useNotDispatched(#[codec(skip)] Option<DispatchBlobError>)
? Functionally, it's the same as now, but this way we can remove the error strings.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oki, lets remove &str stuff, and why do we need
Option
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Done. Reverted the 2nd commit. PTAL.
Deriving
Decode
needs a type that implementsDefault
. Because for example when we derivesDecode
forNotDispatched(#[codec(skip)] Option<DispatchBlobError>)
, sinceOption<DispatchBlobError>
is skipped at encoding time, it won't be present at decoding time and we wouldn't know what kind ofDispatchBlobError
to create. So we creates aNotDispatched(Default::default())
. andDispatchBlobError
doesn't implementDefault
either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aha, ok, got it, thank you