Statement-store: Propagate all statements to newly connected peers by bkchr · Pull Request #10718 · paritytech/polkadot-sdk

bkchr · 2026-01-02T13:41:30Z

No description provided.

alexggh · 2026-01-05T09:36:27Z

substrate/client/network/statement/src/lib.rs

+
+				if !self.sync.is_major_syncing() {
+					if let Ok(statements) = self.statement_store.statements() {
+						self.send_statements_to_peer(&peer, &statements).await;


This will keep this loop busy until all statements are sent, which potentially are many.

I wonder if we don't want to move this out on separate task/thread, but that could easily be a follow up.

alexggh · 2026-01-05T09:40:47Z

substrate/client/network/statement/src/lib.rs

 				debug_assert!(_was_in.is_none());
+
+				if !self.sync.is_major_syncing() {
+					if let Ok(statements) = self.statement_store.statements() {


I would also add a test for it.

P1sar · 2026-01-07T12:00:02Z

Related to #10046

…re-all

bkchr · 2026-01-08T15:31:26Z

/cmd prdoc --audience node_dev --bump major

…e_dev --bump major'

paritytech-workflow-stopper · 2026-01-08T20:21:02Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/20830127938
Failed job name: build-rustdoc

substrate/primitives/statement-store/src/store_api.rs

alexggh

Had a second look over the newly added changes, looks good to me!

Thank you!

AndreiEres

LGTM, thank you! Left a few nits.

AndreiEres · 2026-01-09T13:07:45Z

prdoc/pr_10718.prdoc

+- audience: Node Dev
+  description: |
+    When a new node connects, we now propagate all statements in our store to them. This happens in bursts of ~1MiB messages
+    over time to not completley use up all resources. If multiple peers are connecting, round robin between them. 


Suggested change

over time to not completley use up all resources. If multiple peers are connecting, round robin between them.

over time to not completely use up all resources. If multiple peers are connecting, round robin between them.

AndreiEres · 2026-01-09T13:13:11Z

substrate/client/statement-store/src/lib.rs

+					result.push((*hash, statement));
+				},
+				FilterDecision::Abort => {
+					// We did not process it :)


nit: we can increase it after match filter

AndreiEres · 2026-01-09T13:17:28Z

substrate/client/statement-store/src/lib.rs

 	}

+	fn statement_hashes(&self) -> Result<Vec<Hash>> {
+		Ok(self.index.read().entries.keys().cloned().collect())


Do we need Result here?

AndreiEres · 2026-01-09T13:19:48Z

substrate/client/network/statement/src/lib.rs

+		let (statements, processed) = match self.statement_store.statements_by_hashes(
+			&entry.get().hashes,
+			&mut |_hash, encoded, _stmt| {
+				if accumulated_size > 0 &&


Should we process Skip for oversized statements here as well?

AndreiEres · 2026-01-09T13:25:14Z

substrate/client/statement-store/src/lib.rs

+		for hash in hashes {
+			processed += 1;
+			let Some(encoded) =
+				self.db.get(col::STATEMENTS, hash).map_err(|e| Error::Db(e.to_string()))?


We abandon already processed statements here, maybe we could send them?

AndreiEres · 2026-01-09T13:27:36Z

substrate/client/network/statement/src/lib.rs

+			Ok(r) => r,
+			Err(e) => {
+				log::debug!(target: LOG_TARGET, "Failed to fetch statements for initial sync: {e:?}");
+				entry.remove();


There is no retry mechanism, so the peer has no more chance to receive smth? Maybe we can at least error! it?

AndreiEres · 2026-01-09T13:35:22Z

substrate/client/network/statement/src/lib.rs

 const LOG_TARGET: &str = "statement-gossip";
 /// Maximim time we wait for sending a notification to a peer.
 const SEND_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(10);
+/// Interval for sending statement batches during initial sync to new peers.


nit: initial sync every time misleads me to startup time of the current peer

AndreiEres · 2026-01-09T13:36:39Z

substrate/client/network/statement/src/lib.rs

+}
+
+/// Result of finding a sendable chunk of statements.
+enum ChunkResult {


nit: FindChunkResult?

AndreiEres · 2026-01-09T14:10:20Z

substrate/client/network/statement/src/lib.rs

+				self.pending_initial_syncs.remove(&peer_id);
+				return;
+			},
+			SendChunkResult::Sent(_) => {


nit: debug_assert!(to_sent.len(), sent)?

# Description This follow-up PR addresses review comments from PR #10718: - Removed unnecessary Result wrapper from statement_hashes() - method is infallible - Added debug assertion to validate sent count matches prepared count ## Integration Should not affect downstream projects.

…aritytech#10718) Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…ew (paritytech#10770) # Description This follow-up PR addresses review comments from PR paritytech#10718: - Removed unnecessary Result wrapper from statement_hashes() - method is infallible - Added debug assertion to validate sent count matches prepared count ## Integration Should not affect downstream projects.

bkchr added the T0-node This PR/Issue is related to the topic “node”. label Jan 2, 2026

Statement-store: Propagate all statements to newly connected peers

7e0277c

bkchr force-pushed the bkchr-statement-store-all branch from 1c63bc1 to 7e0277c Compare January 2, 2026 13:43

alexggh requested review from AndreiEres and alexggh January 2, 2026 13:44

AndreiEres approved these changes Jan 5, 2026

View reviewed changes

AndreiEres mentioned this pull request Jan 5, 2026

statement-store further improvements #10046

Closed

5 tasks

alexggh approved these changes Jan 5, 2026

View reviewed changes

bkchr added 2 commits January 8, 2026 16:24

Send out initial statements in bursts

9503ea9

Merge remote-tracking branch 'origin/master' into bkchr-statement-sto…

2f614e5

…re-all

github-actions bot and others added 3 commits January 8, 2026 15:34

Update from github-actions[bot] running command 'prdoc --audience nod…

0a4b265

…e_dev --bump major'

Small improvements

d8f227b

Fix compilation

a428d97

bkchr commented Jan 8, 2026

View reviewed changes

substrate/primitives/statement-store/src/store_api.rs Outdated Show resolved Hide resolved

Apply suggestion from @bkchr

c72112e

alexggh approved these changes Jan 9, 2026

View reviewed changes

bkchr added this pull request to the merge queue Jan 9, 2026

Merged via the queue into master with commit 9426936 Jan 9, 2026
235 of 239 checks passed

bkchr deleted the bkchr-statement-store-all branch January 9, 2026 14:02

AndreiEres reviewed Jan 9, 2026

View reviewed changes

AndreiEres added a commit that referenced this pull request Jan 12, 2026

Statement-store: Follow-up improvements from PR #10718 review

84f05b0

AndreiEres mentioned this pull request Jan 12, 2026

Statement-store: Follow-up improvements from PR #10718 review #10770

Merged

acatangiu pushed a commit to acatangiu/polkadot-sdk that referenced this pull request Jan 14, 2026

Statement-store: Propagate all statements to newly connected peers (p…

c8b9707

…aritytech#10718) Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

alexggh mentioned this pull request Jan 16, 2026

statement-store: rebroadcast statemenets from storage #10819

Closed

pgherveou added this to [preview] release tracker Mar 31, 2026

github-project-automation bot moved this to Todo in [preview] release tracker Mar 31, 2026

github-project-automation bot moved this from Todo to Done in [preview] release tracker Mar 31, 2026

	over time to not completley use up all resources. If multiple peers are connecting, round robin between them.
	over time to not completely use up all resources. If multiple peers are connecting, round robin between them.

Conversation

bkchr commented Jan 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

P1sar commented Jan 7, 2026

Uh oh!

bkchr commented Jan 8, 2026

Uh oh!

paritytech-workflow-stopper bot commented Jan 8, 2026

Uh oh!

Uh oh!

alexggh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AndreiEres left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants