Skip to content

Snowbridge Ethereum client spec fix#10793

Merged
bkontur merged 11 commits intoparitytech:masterfrom
claravanstaden:ethereum-spec-fix
Jan 26, 2026
Merged

Snowbridge Ethereum client spec fix#10793
bkontur merged 11 commits intoparitytech:masterfrom
claravanstaden:ethereum-spec-fix

Conversation

@claravanstaden
Copy link
Copy Markdown
Contributor

@claravanstaden claravanstaden commented Jan 13, 2026

This PR fixes a minor discrepancy in the Snowbridge Ethereum cient pallet where the fork version for sync committee signature verification was derived from signature_slot instead of signature_slot - 1 as required by the https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/sync-protocol.md#validate_light_client_update. This caused valid light client updates to be rejected at Ethereum hard-fork boundaries. The impact is low severity - only affecting liveness once or twice a year for a few minutes. Origin: bug bounty report.

@claravanstaden claravanstaden marked this pull request as ready for review January 15, 2026 14:33
@claravanstaden
Copy link
Copy Markdown
Contributor Author

Need labels T15-bridges and A4-backport-stable2512 please.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 15, 2026 14:47
@acatangiu acatangiu added T15-bridges This PR/Issue is related to bridges. A4-backport-stable2512 Pull request must be backported to the stable2512 release branch labels Jan 19, 2026
@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented Jan 26, 2026

/cmd fmt

@bkontur bkontur enabled auto-merge January 26, 2026 08:27
auto-merge was automatically disabled January 26, 2026 08:41

Head branch was pushed to by a user without write access

@bkontur bkontur enabled auto-merge January 26, 2026 09:05
@bkontur bkontur added this pull request to the merge queue Jan 26, 2026
Merged via the queue into paritytech:master with commit 2da3987 Jan 26, 2026
206 of 208 checks passed
paritytech-release-backport-bot bot pushed a commit that referenced this pull request Jan 26, 2026
This PR fixes a minor discrepancy in the Snowbridge Ethereum cient
pallet where the fork version for sync committee signature verification
was derived from `signature_slot` instead of `signature_slot - 1` as
required by the
https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/sync-protocol.md#validate_light_client_update.
This caused valid light client updates to be rejected at Ethereum
hard-fork boundaries. The impact is low severity - only affecting
liveness once or twice a year for a few minutes. Origin: bug bounty
report.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 2da3987)
@paritytech-release-backport-bot
Copy link
Copy Markdown

Successfully created backport PR for stable2512:

EgorPopelyaev added a commit that referenced this pull request Feb 4, 2026
Backport #10793 into `stable2512` from claravanstaden.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Egor_P <egor@parity.io>
arturgontijo pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Apr 1, 2026
Backport paritytech#10793 into `stable2512` from claravanstaden.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Egor_P <egor@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A4-backport-stable2512 Pull request must be backported to the stable2512 release branch T15-bridges This PR/Issue is related to bridges.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants