Cumulus: Simplify parent search for block-building#10998
Merged
Conversation
Contributor
Author
|
/cmd prdoc --audience node_dev --bump major |
…e_dev --bump major'
Contributor
Author
|
/cmd fmt |
iulianbarbu
approved these changes
Feb 18, 2026
Contributor
Author
|
/cmd fmt |
lexnv
approved these changes
Feb 18, 2026
lexnv
added a commit
that referenced
this pull request
Mar 6, 2026
This reverts commit 37c9bed. Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #10973 I found once more that our parent search is totally overengineered:
By eliminating these two annoyances, the code is a lot more simple and easier to follow. There are still some defensive checks that are not strictly necessary, but does not hurt to keep them.
In summary, the mental model is: Build on the latest descendant of the pending block that is still inside the relay parent ancestry. If no pending block is available, use the included block in its place.