prefix_logs_with: Ensure the macro works correctly for futures#11095
Merged
prefix_logs_with: Ensure the macro works correctly for futures#11095
prefix_logs_with: Ensure the macro works correctly for futures#11095Conversation
When setting up a tracing span in an async future, it may gets invalidated by any `await` point. The problem is that after continuing a future, it may runs on a different thread where the `span` isn't active anymore. The solution for this is to `instrument` the future properly.
Member
Author
|
/cmd prdoc --audience node_dev --bump patch |
…e_dev --bump patch'
Contributor
|
@bkchr Can we replace this one here directly? |
skunert
approved these changes
Feb 18, 2026
lexnv
approved these changes
Feb 18, 2026
Contributor
lexnv
left a comment
lexnv
left a comment
There was a problem hiding this comment.
Nice! This will make collators with minimal-rpc nodes happy 🙏
iulianbarbu
approved these changes
Feb 18, 2026
Member
Author
No. This returns a future. This doesn't work there. |
lrubasze
approved these changes
Feb 19, 2026
| doc: | ||
| - audience: Node Dev | ||
| description: |- | ||
| When setting up a tracing span in an async future, it may gets invalidated by any `await` point. The problem is that after continuing a future, it may runs on a different thread where the `span` isn't active anymore. The solution for this is to `instrument` the future properly. |
Contributor
There was a problem hiding this comment.
Suggested change
| When setting up a tracing span in an async future, it may gets invalidated by any `await` point. The problem is that after continuing a future, it may runs on a different thread where the `span` isn't active anymore. The solution for this is to `instrument` the future properly. | |
| When setting up a tracing span in an async future, it may get invalidated by any `await` point. The problem is that after continuing a future, it may run on a different thread where the `span` isn't active anymore. The solution for this is to `instrument` the future properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting up a tracing span in an async future, it may gets invalidated by any
awaitpoint. The problem is that after continuing a future, it may runs on a different thread where thespanisn't active anymore. The solution for this is toinstrumentthe future properly.