Add kick_member to Society pallet by laurogripa · Pull Request #11154 · paritytech/polkadot-sdk

laurogripa · 2026-02-23T22:51:46Z

Adds a kick_member extrinsic to pallet-society, callable by the Founder, that removes a member,slashes its payout and returns funds to the Society pot.

Context

Recently, a collusion was discovered where a member managed to claim membership without providing PoI. This change introduces a way for the Founder to kick and slash the bad actors.

laurogripa · 2026-02-23T22:53:51Z

/cmd prdoc --audience runtime_dev --bump minor

…time_dev --bump minor'

laurogripa · 2026-02-23T23:01:10Z

/cmd label T1-FRAME

substrate/frame/society/src/lib.rs

bkchr · 2026-03-04T19:30:28Z

/cmd fmt

sigurpol · 2026-03-04T20:14:19Z

substrate/frame/society/src/lib.rs

+			);
+			let who = T::Lookup::lookup(who)?;
+
+			Self::slash_payout(&who, BalanceOf::<T, I>::max_value());


is it intentional that we don't call unreserve_payout() unlike what we do in judge_suspended_member?

Just wondering if the correct pattern is the one in judge_suspended_member or the one in strike_member where we also don't call unreserve_payout...

re-reading the code... I believe not calling unreserve_payout is a bug both here and in strike_member.
In the end the scope of the PR is to give super powers to the founder to force-suspend a member so as I see it, kick_member = suspend_member(who) + judge_suspended_member(who, false)

is it intentional that we don't call unreserve_payout() unlike what we do in judge_suspended_member?

Yeah good point. I read the code also again and it looks like slash_payout is actually broken.

In this case, shouldn't unreserve_payout be coupled with slash_payout every time i.e. unreserve_payout should be called inside slash_payout, at the end?

I also think so honestly - but it's up to you if you prefer a very punctual fix for the kick_member case only in this PR and have any other fix / refactor / improvement for later or not. I am fine with both approaches.

I would be fine with a very minimal change like

let slashed = Self::slash_payout(&who, BalanceOf::<T, I>::max_value()); Self::unreserve_payout(slashed); Self::suspend_member(&who).map(drop)

or with fixing slash payout as you suggest - or going for @bkchr' suggestion to go with remove_member - all works for me.

If I have to choose one, I think the cleaner is remove_member + unreserve_payout (+ KickedMember event)

a variant with remove_member here: cb6a9ff PTAL and let me know if it makes sense

substrate/frame/society/src/lib.rs

sigurpol · 2026-03-04T20:19:55Z

substrate/frame/society/src/lib.rs

+		/// - `who`: The member to be suspended.
+		#[pallet::call_index(21)]
+		#[pallet::weight(T::WeightInfo::kick_member())]
+		pub fn kick_member(origin: OriginFor<T>, who: AccountIdLookupOf<T>) -> DispatchResult {


should we add an ad-hoc event to the list https://github.com/paritytech/polkadot-sdk/blob/kick-member-society-extrinsic/substrate/frame/society/src/lib.rs#L626-L626 or we are fine with just MemberSuspended?

Yeah, we probably don't need to call suspend_member at all.

@bkchr wdym? just call remove_member instead?

My rationale here was to treat kicking the same way as a regular suspension, adding the kicked member to the SuspendedMembers list, but in this case, I guess it makes sense to simply remove straight away

I can replace suspend_member with remove_member and add a MemberKicked event here, if it makes sense.

However, I think there are a few places where the events in this pallet can be improved. There's no event for claim_membership iirc, which is arguably the most important event. I plan to propose a set of improvements after we deal with this.

I can take care of backporting to 2512, merge there, ask rel team to publish a new crate and finally bump the crate version in the runtime PR for 2.1.0, don't worry. No need to open upgrade proposal, it will be part of 2.1.0 (cc @ggwpez )

also westend doesn't have society pallet so my /cmd bench errored out 😓 it would make sense to generate benchmarks for kusama only there. Here only rococo seems to support it but no point in regenerate weights there so we are good to merge I believe.

I can take care of backporting to 2512, merge there, ask rel team to publish a new crate and finally bump the crate version in the runtime PR for 2.1.0, don't worry. No need to open upgrade proposal, it will be part of 2.1.0 (cc @ggwpez )

Okay! Do you think 2.1.0 can be enacted in the next 7 days or so? The bad actor's payout will mature in block 32,716,826. We also need 1 or 2 days of buffer ideally, so the Founder can call the extrinsic

cc @ggwpez - the plan would be if all planets are aligned (mostly CI, especially runtime CI) to make a referendum for Kusama by end of this week. Realistically I don't think we will have the PR for bumping crates and to rerun pallet-society crates ready before end of tomorrow (we need to wait for this PR to be merged, backported one to be merged, crate to be published, PR runtime to run benchmarks and be green and reviewed). I believe it's doable if we can make a very short referendum on Kusama.

polkadot-fellows/runtimes#1080 has just been merged by @ggwpez and contains the fix for kick_member - once runtime is built there will be a referendum @laurogripa

substrate/frame/society/src/tests.rs

substrate/frame/society/src/benchmarking.rs

sigurpol · 2026-03-04T21:03:12Z

I have some concerns about merging in the current state but it's also the 1st time I am looking at this code.
My 2c: I honestly don't like what this PR allows but I understand the urgency of the situation and that there is no time for a redesign of the mechanism.
Maybe we should evaluate some way to slash who vouched for the fraudulent member, or to use some collective governance instead of the founder kick or similar... but ok, nothing we can solve immediately.

laurogripa · 2026-03-05T00:07:17Z

I have some concerns about merging in the current state but it's also the 1st time I am looking at this code. My 2c: I honestly don't like what this PR allows but I understand the urgency of the situation and that there is no time for a redesign of the mechanism. Maybe we should evaluate some way to slash who vouched for the fraudulent member, or to use some collective governance instead of the founder kick or similar... but ok, nothing we can solve immediately.

Thanks for the thorough review, @sigurpol!

Agreed, it's not ideal, but it's also temporary. I plan to open an RFC right after this, so we can discuss a better solution (possibly with collective governance and a minimum quorum to avoid further collusions)

laurogripa · 2026-03-05T04:13:04Z

@bkchr @sigurpol guys, thanks for the reviews and discussions!

I fixed the test and updated the benchmark with max payouts.
Regarding the other 2 issues, I left some comments, but not sure about the best approach.

It's night here, so I'll be back in 9 hours or so, but feel free to commit changes if you guys want.

stale

sigurpol · 2026-03-05T10:01:32Z

/cmd bench --pallet pallet_society --runtime collectives-westend

github-actions · 2026-03-05T10:02:23Z

Command "bench --pallet pallet_society --runtime collectives-westend" has started 🚀 See logs here

github-actions · 2026-03-05T11:37:06Z

Command "bench --pallet pallet_society --runtime collectives-westend" has failed ❌! See logs here

bkchr · 2026-03-05T11:46:34Z

/cmd bench --pallet pallet_society --runtime kitchensink-runtime

github-actions · 2026-03-05T11:47:33Z

Command "bench --pallet pallet_society --runtime kitchensink-runtime" has started 🚀 See logs here

github-actions · 2026-03-05T11:49:47Z

Command "bench --pallet pallet_society --runtime kitchensink-runtime" has failed ❌! See logs here

Adds a kick_member extrinsic to pallet-society, callable by the Founder, that removes a member,slashes its payout and returns funds to the Society pot. ### Context Recently, a collusion was discovered where a member managed to claim membership without providing PoI. This change introduces a way for the Founder to kick and slash the bad actors. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Paolo La Camera <paolo@parity.io> (cherry picked from commit 695397f)

paritytech-release-backport-bot · 2026-03-05T13:01:06Z

Successfully created backport PR for stable2512:

[stable2512] Backport #11154 #11280

Adds a kick_member extrinsic to pallet-society, callable by the Founder, that removes a member,slashes its payout and returns funds to the Society pot. ### Context Recently, a collusion was discovered where a member managed to claim membership without providing PoI. This change introduces a way for the Founder to kick and slash the bad actors. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Paolo La Camera <paolo@parity.io> (cherry picked from commit 695397f)

paritytech-release-backport-bot · 2026-03-05T13:01:11Z

Successfully created backport PR for stable2603:

[stable2603] Backport #11154 #11281

Backport #11154 into `stable2512` from laurogripa. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot.  --------- Co-authored-by: Lauro Gripa <laurogripa@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Paolo La Camera <paolo@parity.io>

Backport #11154 into `stable2603` from laurogripa. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot.  --------- Co-authored-by: Lauro Gripa <laurogripa@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Paolo La Camera <paolo@parity.io>

sigurpol · 2026-03-05T17:05:54Z

@laurogripa this is the PR in runtime that contains the fix: polkadot-fellows/runtimes#1101

ggwpez · 2026-03-13T10:46:38Z

Kicking happend here https://assethub-kusama.subscan.io/event/14290025-4

Backport paritytech#11154 into `stable2512` from laurogripa. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot.  --------- Co-authored-by: Lauro Gripa <laurogripa@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Paolo La Camera <paolo@parity.io>

laurogripa added 4 commits February 23, 2026 18:46

Implement kick_member extrinsic in the society pallet

5ec553b

Add tests

ae5afd6

Calculate weights

8b8c98d

Run formatter

d15f51c

laurogripa requested a review from a team as a code owner February 23, 2026 22:51

Update from github-actions[bot] running command 'prdoc --audience run…

d9609d6

…time_dev --bump minor'

paritytech-cmd-bot-polkadot-sdk bot added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Feb 23, 2026

bkchr reviewed Mar 4, 2026

View reviewed changes

substrate/frame/society/src/lib.rs Show resolved Hide resolved

substrate/frame/society/src/lib.rs Outdated Show resolved Hide resolved

Slash everything instead of just half

5b6758d

bkchr reviewed Mar 4, 2026

View reviewed changes

substrate/frame/society/src/lib.rs Outdated Show resolved Hide resolved

bkchr approved these changes Mar 4, 2026

View reviewed changes

substrate/frame/society/src/lib.rs Outdated Show resolved Hide resolved

bkchr added 2 commits March 4, 2026 20:30

Update substrate/frame/society/src/lib.rs

5c7d4e4

Update substrate/frame/society/src/lib.rs

d718a02

Update from github-actions[bot] running command 'fmt'

554c96c

bkchr enabled auto-merge March 4, 2026 19:34

Add Bounded trait to imports in lib.rs

f2c03d4

sigurpol reviewed Mar 4, 2026

View reviewed changes

substrate/frame/society/src/benchmarking.rs Show resolved Hide resolved

laurogripa added 2 commits March 4, 2026 22:17

Fix test

01a93cd

Add payouts to worst-case scenario

44c6c4a

auto-merge was automatically disabled March 5, 2026 03:07
Head branch was pushed to by a user without write access

kianenigma previously approved these changes Mar 5, 2026

View reviewed changes

Merge branch 'master' into kick-member-society-extrinsic

f54bf7e

sigurpol added T2-pallets This PR/Issue is related to a particular pallet. A4-backport-stable2512 Pull request must be backported to the stable2512 release branch A4-backport-stable2603 Pull request must be backported to the stable2603 release branch labels Mar 5, 2026

bkchr approved these changes Mar 5, 2026

View reviewed changes

sigurpol approved these changes Mar 5, 2026

View reviewed changes

sigurpol added this pull request to the merge queue Mar 5, 2026

Merged via the queue into paritytech:master with commit 695397f Mar 5, 2026
277 of 290 checks passed

paritytech-release-backport-bot bot mentioned this pull request Mar 5, 2026

[stable2512] Backport #11154 #11280

Merged

paritytech-release-backport-bot bot mentioned this pull request Mar 5, 2026

[stable2603] Backport #11154 #11281

Merged

laurogripa deleted the kick-member-society-extrinsic branch March 5, 2026 13:50

pgherveou added this to [preview] release tracker Mar 25, 2026

github-project-automation bot moved this to Todo in [preview] release tracker Mar 25, 2026

github-project-automation bot moved this from Todo to Done in [preview] release tracker Mar 25, 2026

Conversation

laurogripa commented Feb 23, 2026 • edited by sigurpol Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Uh oh!

laurogripa commented Feb 23, 2026

Uh oh!

laurogripa commented Feb 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkchr commented Mar 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sigurpol Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sigurpol commented Mar 4, 2026

Uh oh!

laurogripa commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laurogripa commented Mar 5, 2026

Uh oh!

sigurpol commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

bkchr commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

Uh oh!

paritytech-release-backport-bot bot commented Mar 5, 2026

Uh oh!

paritytech-release-backport-bot bot commented Mar 5, 2026

Uh oh!

sigurpol commented Mar 5, 2026

Uh oh!

laurogripa commented Feb 23, 2026 •

edited by sigurpol

Loading

sigurpol Mar 5, 2026 •

edited

Loading

laurogripa commented Mar 5, 2026 •

edited

Loading