Skip to content

add scheduling tests for v3 descriptor with v2 collators#11333

Merged
iulianbarbu merged 62 commits intomasterfrom
mchr-v3-descriptor-tests
Mar 26, 2026
Merged

add scheduling tests for v3 descriptor with v2 collators#11333
iulianbarbu merged 62 commits intomasterfrom
mchr-v3-descriptor-tests

Conversation

@mchristou
Copy link
Copy Markdown
Contributor

@mchristou mchristou commented Mar 10, 2026 •
edited
Loading

Description:

Zombienet SDK tests (polkadot/zombienet-sdk-tests/tests/scheduling/):

  • v3_dynamic_enablement: relay chain starts with V2, enables V3 on the fly mid-session via governance.
    Verifies block production continues and descriptors are correctly detected after the feature flip
  • v3_rolling_upgrade: mixed V2/V3 validator fleet using async backing. Verifies the network keeps producing blocks during a rolling upgrade where only some validators support V3

Unit tests:

  • paras_inherent/tests.rs: V1 descriptor accepted by V3-capable runtime, verifies candidates reach PendingAvailability
  • collator-protocol/validator_side/tests/prospective_parachains.rs: V3 capable validator correctly detects and handles a V1 descriptor received over the wire
  • configuration/tests.rs: max_relay_parent_session_age returns 0 after v13 migration
  • backing/src/tests/mod.rs: V3 capable validator fully backs a V1 candidate
  • statement-distribution/src/v2/tests/cluster.rs: V1 backed statement is distributed to a V3-capable cluster peer and accepted via the V3 wire protocol

@mchristou mchristou requested review from a team as code owners March 10, 2026 15:15
@mchristou mchristou added the T10-tests This PR/Issue is related to tests. label Mar 10, 2026
@mchristou mchristou requested a review from iulianbarbu March 10, 2026 15:16
@mchristou mchristou changed the title Mchr v3 descriptor tests add scheduling tests for v3 descriptor with v2 collators Mar 10, 2026
sandreim
sandreim reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mchristou !

One suggestion: We could have a single test that starts with v3 disabled, checks if things works, then enables it, wait 1 session then enable it and check if things still work. This way we also cover for dynamic enablement of v3.

sandreim
sandreim reviewed Mar 11, 2026
View reviewed changes
Comment thread polkadot/zombienet-sdk-tests/tests/scheduling/v3_dynamic_enablement.rs Outdated
Comment thread polkadot/zombienet-sdk-tests/tests/functional/v3_dynamic_enablement.rs Outdated
Comment thread polkadot/zombienet-sdk-tests/tests/functional/v3_dynamic_enablement.rs
Comment thread polkadot/zombienet-sdk-tests/tests/scheduling/mod.rs Outdated
Comment thread polkadot/zombienet-sdk-tests/tests/scheduling/v3_elastic_scaling.rs Outdated
@mchristou
Copy link
Copy Markdown
Contributor Author

mchristou commented Mar 11, 2026

Thanks @mchristou !

One suggestion: We could have a single test that starts with v3 disabled, checks if things works, then enables it, wait 1 session then enable it and check if things still work. This way we also cover for dynamic enablement of v3.

I added v3_dynamic_enablement and remove v3_descriptor_enabled and v3_descriptor_disabled since are covered by it.

@mchristou mchristou requested a review from a team as a code owner March 12, 2026 13:09
@mchristou mchristou force-pushed the mchr-v3-descriptor-tests branch from f40cb2b to 8a2aeb9 Compare March 12, 2026 13:11
@mchristou mchristou removed the request for review from a team March 12, 2026 13:12
@iulianbarbu iulianbarbu added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Mar 16, 2026
iulianbarbu
iulianbarbu reviewed Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@iulianbarbu iulianbarbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Seems though that CI is not yet happy because:

  • validator_side::tests::prospective_parachains::v1_descriptor_version_detection_with_v3_enabled is failing
  • fmt needs fixing

Comment thread .github/zombienet-tests/zombienet_polkadot_tests.yml Outdated
@mchristou
Copy link
Copy Markdown
Contributor Author

mchristou commented Mar 16, 2026

/cmd fmt

@iulianbarbu
address some more review comments
e6418a1 
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
@iulianbarbu
Copy link
Copy Markdown
Contributor

iulianbarbu commented Mar 24, 2026

/cmd fmt

github-actions bot and others added 2 commits March 24, 2026 14:44
@iulianbarbu
Copy link
Copy Markdown
Contributor

iulianbarbu commented Mar 24, 2026

/cmd fmt

@iulianbarbu
Copy link
Copy Markdown
Contributor

iulianbarbu commented Mar 25, 2026

/cmd fmt

@iulianbarbu iulianbarbu requested a review from alindima March 25, 2026 09:09
alindima
alindima reviewed Mar 25, 2026
View reviewed changes
Comment thread polkadot/runtime/parachains/src/paras_inherent/tests.rs Outdated
Comment thread polkadot/zombienet-sdk-tests/tests/functional/v3_dynamic_enablement.rs Outdated
Comment thread polkadot/node/network/collator-protocol/src/validator_side/tests/prospective_parachains.rs Outdated
iulianbarbu and others added 4 commits March 25, 2026 19:21
@iulianbarbu
polkadot(tests): refactor v3 wise
16777eb 
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
@iulianbarbu
polkadot(tests): address a few more review comments
d6806f4 
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
@iulianbarbu
Merge branch 'master' into mchr-v3-descriptor-tests
43c74ce
@iulianbarbu
polkadot(tests): remove unneeded tests
ad65e56 
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
@0bmario 0bmario mentioned this pull request Mar 25, 2026
Open
4 tasks
iulianbarbu and others added 6 commits March 25, 2026 19:49
@iulianbarbu
polkadot(tests): remove uneeded tests for v3
86b6ca9 
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
@iulianbarbu
fix clippy
b85b9dc 
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
@iulianbarbu
rename test
8b289d2 
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
@iulianbarbu
polkadot(zn-tests): use enable_node_feature is systemic chnk recovery
72ac5e2 
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
@iulianbarbu
fix clippy again
f82d312 
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
@iulianbarbu
Merge branch 'master' into mchr-v3-descriptor-tests
5a121a1
alindima
alindima approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @mchristou and @iulianbarbu !

@iulianbarbu iulianbarbu added this pull request to the merge queue Mar 26, 2026
Merged via the queue into master with commit f4a82c9 Mar 26, 2026
324 of 327 checks passed
@iulianbarbu iulianbarbu deleted the mchr-v3-descriptor-tests branch March 26, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iulianbarbu iulianbarbu iulianbarbu left review comments

@sandreim sandreim sandreim left review comments

@eskimor eskimor eskimor approved these changes

@alindima alindima alindima approved these changes

Assignees

No one assigned

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published. T10-tests This PR/Issue is related to tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mchristou @iulianbarbu @eskimor @alindima @sandreim @pgherveou