Skip to content

statement-store: read allowance on best hash#11667

Merged
AndreiEres merged 5 commits intomasterfrom
alexggh/check-allowance-on-best
Apr 8, 2026
Merged

statement-store: read allowance on best hash#11667
AndreiEres merged 5 commits intomasterfrom
alexggh/check-allowance-on-best

Conversation

@alexggh
Copy link
Copy Markdown
Contributor

@alexggh alexggh commented Apr 7, 2026

To allow accepting statements as early as possible

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh alexggh added the A4-backport-stable2603 Pull request must be backported to the stable2603 release branch label Apr 7, 2026
@alexggh alexggh requested a review from P1sar April 7, 2026 12:59
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Review required! Latest push from author must always be reviewed

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh alexggh requested review from AndreiEres and P1sar April 7, 2026 14:34
Co-authored-by: Andrei Eres <eresav@me.com>
Copy link
Copy Markdown
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the statement store system's weak coherence, allowances are not something precise, so it's okay to use values that are not guaranteed.

@alexggh alexggh enabled auto-merge April 8, 2026 06:11
@alexggh alexggh added this pull request to the merge queue Apr 8, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2026
@AndreiEres AndreiEres added this pull request to the merge queue Apr 8, 2026
Merged via the queue into master with commit 4050536 Apr 8, 2026
253 of 256 checks passed
@AndreiEres AndreiEres deleted the alexggh/check-allowance-on-best branch April 8, 2026 08:40
@paritytech-release-backport-bot
Copy link
Copy Markdown

Successfully created backport PR for stable2603:

paritytech-release-backport-bot bot pushed a commit that referenced this pull request Apr 8, 2026
To allow accepting statements as early as possible

---------

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Co-authored-by: Andrei Eres <eresav@me.com>
(cherry picked from commit 4050536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A4-backport-stable2603 Pull request must be backported to the stable2603 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants