Conversation
Fix a check from `log::warn! -> ensure!`, add more comments to each, and order them for legibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up to #11068. It contains suggestions - for
try_statechecks and pallet unit tests - that were not made before it was merged.It is also a companion to open-web3-stack/polkadot-ecosystem-tests#592 .
Any comments or suggestions appreciated (pinging @lrazovic since you authored #11068)..
Integration
N/A
Review Notes
try_statechecks topallet-psmfn do_try_stateon valid statedo_try_statefails appropriately on several different kinds of invalidpallet-psmstates