Skip to content

Add more pallet-psm tests#11805

Open
rockbmb wants to merge 3 commits intomasterfrom
psm-try-state-checks
Open

Add more pallet-psm tests#11805
rockbmb wants to merge 3 commits intomasterfrom
psm-try-state-checks

Conversation

@rockbmb
Copy link
Copy Markdown
Contributor

@rockbmb rockbmb commented Apr 16, 2026

Description

This PR is a follow-up to #11068. It contains suggestions - for try_state checks and pallet unit tests - that were not made before it was merged.
It is also a companion to open-web3-stack/polkadot-ecosystem-tests#592 .

Any comments or suggestions appreciated (pinging @lrazovic since you authored #11068)..

Integration

N/A

Review Notes

  • add more try_state checks to pallet-psm
  • add a test that verifies expected behavior of fn do_try_state on valid state
  • add unit tests that verify do_try_state fails appropriately on several different kinds of invalid pallet-psm states
  • cover some additional edge cases regarding multi-asset ceiling boundaries
  • add a basic generator-based fuzzer, and perform a short campaign to validate it.

rockbmb added 3 commits April 16, 2026 18:00
Fix a check from `log::warn! -> ensure!`, add more comments to each,
and order them for legibility.
@rockbmb rockbmb self-assigned this Apr 16, 2026
@rockbmb rockbmb requested a review from a team as a code owner April 16, 2026 22:07
@rockbmb rockbmb added T2-pallets This PR/Issue is related to a particular pallet. T10-tests This PR/Issue is related to tests. labels Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T2-pallets This PR/Issue is related to a particular pallet. T10-tests This PR/Issue is related to tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant