migrate alliance, fast-unstake and bags list to use derive-impl by kianenigma · Pull Request #1636 · paritytech/polkadot-sdk

kianenigma · 2023-09-19T15:17:44Z

Moving a few pallets to the latest and greatest derive_impl to give it a try.

Part of #171

Co-authored-by: Adrian Catangiu <adrian@parity.io>

…:paritytech/polkadot-sdk into kiz-migrat-some-pallet-to-default-config

…migrat-some-pallet-to-default-config

This reverts commit b304cfd.

gupnik · 2023-09-21T05:08:07Z

 		item.ident != "RuntimeEvent" &&
 		item.ident != "RuntimeOrigin" &&
+		item.ident != "RuntimeHoldReason" &&
+		item.ident != "RuntimeFreezeReason" &&


Would be good to modify the error message as well.

…migrat-some-pallet-to-default-config

liamaharon · 2023-09-21T11:27:36Z

-	type SS58Prefix = ();
-	type OnSetCode = ();
-	type MaxConsumers = frame_support::traits::ConstU32<16>;
+	// we use U128 account id in this pallet for a good reason.


what is the 'good reason'? should we mention it in this comment?

I had mixed this in nomination-pools, where we do use u128 such that the process of converting a pool id into account id would work and yield different numbers. I actually don't know the reason for this, and will try and move it to u32.

It seems to have something to do with iteration order -- with u128, if I insert 1 and 2 into a map and then iter on it, I get it back in the same order, but not with u32.

the right behavior is actually to be agnostic to the order, as the pallet makes no guarantees there.

liamaharon · 2023-09-21T11:28:22Z

-	type OnSetCode = ();
-
 	type AccountData = pallet_balances::AccountData<u64>;
+	// This pallet wishes to overwrite this.


I am not aware tbh, but somehow in the test setu they wishes to on;y allow balances and remark transactions. Probably to test that any call filter here cannot be bipassed by being wrapped in a multisig.

liamaharon · 2023-09-21T11:30:07Z

@@ -877,6 +877,8 @@ pub fn inject_runtime_type(_: TokenStream, tokens: TokenStream) -> TokenStream {
 	if item.ident != "RuntimeCall" &&


I'd love to see docs on these macros

Docs are available here:

polkadot-sdk/substrate/frame/support/src/lib.rs

Line 844 in cfc6cc6

pub use frame_support_procedural::inject_runtime_type;

franciscoaguirre

Love inject_runtime_type ❤️

paritytech-cicd-pr · 2023-09-25T18:42:44Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3792143

KiChjang · 2023-09-26T13:22:48Z

 			#[inject_runtime_type]
 			type RuntimeEvent = ();
+			#[inject_runtime_type]
+			type RuntimeHoldReason = ();


Huh, when we have #[inject_runtime_type] here, does it actually mean that the RHS here can be anything we want, and it wouldn't matter?

It can be any type (as long as it is a valid type identifier) and any type is valid because in DefaultConfig it is merely a type RuntimeHoldReason with no bounds.

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

* master: (24 commits) Init System Parachain storage versions and add migration check jobs to CI (#1344) no-bound derives: Use absolute path for `core` (#1763) migrate alliance, fast-unstake and bags list to use derive-impl (#1636) Tvl pool staking (#1322) improve service error (#1734) frame-support: `RuntimeDebug\Eq\PartialEq` impls for `Imbalance` (#1717) Point documentation links to monorepo (#1741) [NPoS] Fix for Reward Deficit in the pool (#1255) Move import queue from `ChainSync` to `SyncingEngine` (#1736) Enable mocking contracts (#1331) Revert "fix(review-bot): pull secrets from `master` environment" (#1748) Remove kusama and polkadot runtime crates (#1731) Use `Extensions` to register offchain worker custom extensions (#1719) [RPC-Spec-V2] chainHead: use integer for block index and adjust RuntimeVersion JSON format (#1666) fix(review-bot): pull secrets from `master` environment (#1745) Fix `subkey inspect` output text padding (#1744) archive: Implement height, hashByHeight and call (#1582) rpc/client: Propagate `rpc_methods` method to reported methods (#1713) rococo-runtime: `RococoGenesisExt` removed (#1490) PVF: more filesystem sandboxing (#1373) ...

* tsv-disabling-node-side: (24 commits) Init System Parachain storage versions and add migration check jobs to CI (#1344) no-bound derives: Use absolute path for `core` (#1763) migrate alliance, fast-unstake and bags list to use derive-impl (#1636) Tvl pool staking (#1322) improve service error (#1734) frame-support: `RuntimeDebug\Eq\PartialEq` impls for `Imbalance` (#1717) Point documentation links to monorepo (#1741) [NPoS] Fix for Reward Deficit in the pool (#1255) Move import queue from `ChainSync` to `SyncingEngine` (#1736) Enable mocking contracts (#1331) Revert "fix(review-bot): pull secrets from `master` environment" (#1748) Remove kusama and polkadot runtime crates (#1731) Use `Extensions` to register offchain worker custom extensions (#1719) [RPC-Spec-V2] chainHead: use integer for block index and adjust RuntimeVersion JSON format (#1666) fix(review-bot): pull secrets from `master` environment (#1745) Fix `subkey inspect` output text padding (#1744) archive: Implement height, hashByHeight and call (#1582) rpc/client: Propagate `rpc_methods` method to reported methods (#1713) rococo-runtime: `RococoGenesisExt` removed (#1490) PVF: more filesystem sandboxing (#1373) ...

… frame_system (#3317) # Description This PR removes redundant type definition from test definition config implementations like ``` #[derive_impl(frame_system::config_preludes::TestDefaultConfig as frame_system::DefaultConfig)] impl frame_system::Config for Test { type A = A; ... } ``` This changes avoid redundancies in the code as the macro `derive_impl` defines the relevant types. To implement the changes, it was a simple fact of running tests and making sure that the tests would still run while the definition would be removed. Closes #3237 As a note, here is a brief account of things done from the Issue's description statement ``` alliance migrate alliance, fast-unstake and bags list to use derive-impl #1636 asset-conversion DONE asset-rate DONE assets DONE atomic-swap DONE aura DONE authority-discovery DONE authorship migrate babe and authorship to use derive-impl #1790 babe migrate babe and authorship to use derive-impl #1790 bags-list migrate alliance, fast-unstake and bags list to use derive-impl #1636 balances DONE beefy NOTHING TO DO --- also noted this error without failing tests Feb 13 13:49:08.941 ERROR runtime::timestamp: `pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0 beefy-mmr NOTHING TO DO bounties DONE child-bounties DONE collective DONE contracts DONE conviction-voting DONE core-fellowship NOTHING TO DO democracy DONE election-provider-multi-phase NOTHING TO DO elections-phragmen DONE executive NOTHING TO DO fast-unstake migrate alliance, fast-unstake and bags list to use derive-impl #1636 glutton DONE grandpa DONE identity DONE im-online NOTHING TO DO indices Refactor indices pallet #1789 insecure-randomness-collective-flip DONE lottery DONE membership DONE merkle-mountain-range NOTHING TO DO message-queue DONE multisig add frame_system::DefaultConfig to individual pallet DefaultConfigs substrate#14453 nft-fractionalization DONE nfts DONE nicks Refactor pallet-state-trie-migration to fungible::* traits #1801 NOT IN REPO nis DONE node-authorization DONE nomination-pools NOTHING TO DO -- ONLY impl for Runtime offences DELETED EVERYTHING -- IS THAT CORRECT?? preimage DONE proxy add frame_system::DefaultConfig to individual pallet DefaultConfigs substrate#14453 ranked-collective NOTHING TO DO recovery DONE referenda DONE remark DONE root-offences DONE root-testing NOTHING TO DO salary NOTHING TO DO scheduler DONE scored-pool DONE session DONE -- substrate/frame/session/benchmarking/src/mock.rs untouched society NOTHING TO DO staking DONE staking-bags-benchmarks NOT IN REPO state-trie-migration NOTHING TO DO statement DONE sudo DONE system DONE timestamp DONE tips DONE transaction-payment NOTHING TO DO transaction-storage NOTHING TO DO treasury DONE try-runtime NOTHING TO DO -- no specific mention of 'for Test' uniques DONE utility DONE vesting DONE whitelist DONE ``` --------- Co-authored-by: command-bot <> Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>

…tytech#1636) Moving a few pallets to the latest and greatest `derive_impl` to give it a try. Part of paritytech#171 --------- Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

… frame_system (paritytech#3317) # Description This PR removes redundant type definition from test definition config implementations like ``` #[derive_impl(frame_system::config_preludes::TestDefaultConfig as frame_system::DefaultConfig)] impl frame_system::Config for Test { type A = A; ... } ``` This changes avoid redundancies in the code as the macro `derive_impl` defines the relevant types. To implement the changes, it was a simple fact of running tests and making sure that the tests would still run while the definition would be removed. Closes paritytech#3237 As a note, here is a brief account of things done from the Issue's description statement ``` alliance migrate alliance, fast-unstake and bags list to use derive-impl paritytech#1636 asset-conversion DONE asset-rate DONE assets DONE atomic-swap DONE aura DONE authority-discovery DONE authorship migrate babe and authorship to use derive-impl paritytech#1790 babe migrate babe and authorship to use derive-impl paritytech#1790 bags-list migrate alliance, fast-unstake and bags list to use derive-impl paritytech#1636 balances DONE beefy NOTHING TO DO --- also noted this error without failing tests Feb 13 13:49:08.941 ERROR runtime::timestamp: `pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0 beefy-mmr NOTHING TO DO bounties DONE child-bounties DONE collective DONE contracts DONE conviction-voting DONE core-fellowship NOTHING TO DO democracy DONE election-provider-multi-phase NOTHING TO DO elections-phragmen DONE executive NOTHING TO DO fast-unstake migrate alliance, fast-unstake and bags list to use derive-impl paritytech#1636 glutton DONE grandpa DONE identity DONE im-online NOTHING TO DO indices Refactor indices pallet paritytech#1789 insecure-randomness-collective-flip DONE lottery DONE membership DONE merkle-mountain-range NOTHING TO DO message-queue DONE multisig add frame_system::DefaultConfig to individual pallet DefaultConfigs substrate#14453 nft-fractionalization DONE nfts DONE nicks Refactor pallet-state-trie-migration to fungible::* traits paritytech#1801 NOT IN REPO nis DONE node-authorization DONE nomination-pools NOTHING TO DO -- ONLY impl for Runtime offences DELETED EVERYTHING -- IS THAT CORRECT?? preimage DONE proxy add frame_system::DefaultConfig to individual pallet DefaultConfigs substrate#14453 ranked-collective NOTHING TO DO recovery DONE referenda DONE remark DONE root-offences DONE root-testing NOTHING TO DO salary NOTHING TO DO scheduler DONE scored-pool DONE session DONE -- substrate/frame/session/benchmarking/src/mock.rs untouched society NOTHING TO DO staking DONE staking-bags-benchmarks NOT IN REPO state-trie-migration NOTHING TO DO statement DONE sudo DONE system DONE timestamp DONE tips DONE transaction-payment NOTHING TO DO transaction-storage NOTHING TO DO treasury DONE try-runtime NOTHING TO DO -- no specific mention of 'for Test' uniques DONE utility DONE vesting DONE whitelist DONE ``` --------- Co-authored-by: command-bot <> Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>

migrate alliance, fast-unstake and bags list to use derive-impl

49b6757

kianenigma requested review from a team September 19, 2023 15:17

kianenigma added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Sep 19, 2023

kianenigma mentioned this pull request Sep 19, 2023

[FRAME Core] tracking issue for full unleash of DefaultConfig for FRAME #171

Open

12 tasks

kianenigma requested a review from gupnik September 19, 2023 15:19

kianenigma added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Sep 19, 2023

acatangiu reviewed Sep 19, 2023

View reviewed changes

Comment thread substrate/frame/alliance/src/mock.rs Outdated

gupnik approved these changes Sep 20, 2023

View reviewed changes

Update substrate/frame/alliance/src/mock.rs

e9b5626

Co-authored-by: Adrian Catangiu <adrian@parity.io>

kianenigma requested a review from acatangiu September 20, 2023 09:00

kianenigma added 3 commits September 20, 2023 13:47

switch default MockBlock to be u32

b304cfd

Merge branch 'kiz-migrat-some-pallet-to-default-config' of github.com…

cd8513b

…:paritytech/polkadot-sdk into kiz-migrat-some-pallet-to-default-config

Merge branch 'master' of github.com:paritytech/polkadot-sdk into kiz-…

b3ae7ce

…migrat-some-pallet-to-default-config

kianenigma requested a review from cheme as a code owner September 20, 2023 11:47

kianenigma added 2 commits September 20, 2023 15:23

Revert "switch default MockBlock to be u32"

a319f93

This reverts commit b304cfd.

update

97f953e

gupnik approved these changes Sep 20, 2023

View reviewed changes

update XCM builder as well

e652c54

kianenigma requested a review from a team as a code owner September 20, 2023 13:41

sam0x17 approved these changes Sep 20, 2023

View reviewed changes

juangirini approved these changes Sep 21, 2023

View reviewed changes

gupnik reviewed Sep 21, 2023

View reviewed changes

Merge branch 'master' of github.com:paritytech/polkadot-sdk into kiz-…

5965703

…migrat-some-pallet-to-default-config

liamaharon approved these changes Sep 21, 2023

View reviewed changes

liamaharon reviewed Sep 21, 2023

View reviewed changes

ggwpez approved these changes Sep 21, 2023

View reviewed changes

kianenigma added 2 commits September 25, 2023 08:47

master.into()

3c74110

update

bfcb62d

franciscoaguirre approved these changes Sep 25, 2023

View reviewed changes

Merge branch 'master' into kiz-migrat-some-pallet-to-default-config

917f54f

bkchr approved these changes Sep 25, 2023

View reviewed changes

KiChjang reviewed Sep 26, 2023

View reviewed changes

Comment thread substrate/frame/bags-list/src/tests.rs Outdated

KiChjang reviewed Sep 26, 2023

View reviewed changes

KiChjang approved these changes Sep 26, 2023

View reviewed changes

kianenigma and others added 4 commits September 26, 2023 21:07

Merge branch 'master' into kiz-migrat-some-pallet-to-default-config

ed28c1c

Update substrate/frame/bags-list/src/tests.rs

8f99359

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

fix

581e218

Merge branch 'master' into kiz-migrat-some-pallet-to-default-config

38f196f

kianenigma merged commit 2ed66a0 into master Oct 1, 2023

kianenigma deleted the kiz-migrat-some-pallet-to-default-config branch October 1, 2023 14:16

kiltbot mentioned this pull request Nov 7, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.2.0 to 1.3.0 KILTprotocol/kilt-node#575

Closed

ahmadkaouk mentioned this pull request Nov 16, 2023

Update polkadot-sdk from v.1.1.0 to v1.3.0 moonbeam-foundation/moonbeam#2565

Closed

gupnik mentioned this pull request Feb 7, 2024

[FRAME Core] remove unnecessary overrides while using derive_impl for frame_system #3237

Closed

71 tasks

		@@ -877,6 +877,8 @@ pub fn inject_runtime_type(_: TokenStream, tokens: TokenStream) -> TokenStream {
		if item.ident != "RuntimeCall" &&

Conversation

kianenigma commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liamaharon Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

franciscoaguirre left a comment

Choose a reason for hiding this comment

Uh oh!

paritytech-cicd-pr commented Sep 25, 2023

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

kianenigma commented Sep 19, 2023 •

edited

Loading

liamaharon Sep 21, 2023 •

edited

Loading