Add MaxTipAmount for pallet-tips#1709
Merged
liamaharon merged 4 commits intoparitytech:masterfrom Sep 28, 2023
Merged
Conversation
|
The CI pipeline was cancelled due to failure one of the required jobs. |
bkchr
approved these changes
Sep 26, 2023
KiChjang
reviewed
Sep 26, 2023
KiChjang
reviewed
Sep 26, 2023
franciscoaguirre
approved these changes
Sep 26, 2023
Contributor
franciscoaguirre
left a comment
franciscoaguirre
left a comment
There was a problem hiding this comment.
I agree the ensure!s should go as early as possible to avoid extra work
liamaharon
approved these changes
Sep 26, 2023
liamaharon
added
the
R1-breaking_change
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v1-3-0/4614/1 |
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Last week we experienced a governance attack. Surprisingly, there was no upper limit on the tip amount. Due to the mechanism of pallet-fragment-election, the council members will be refreshed immediately. Attacker is easy to control the council and give a large tip amount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last week we experienced a governance attack.
Surprisingly, there was no upper limit on the tip amount.
Due to the mechanism of pallet-fragment-election, the council members will be refreshed immediately. Attacker is easy to control the council and give a large tip amount.